Pass secrets to reusable workflow for Maven SNAPSHOT deployment#248
Merged
Pass secrets to reusable workflow for Maven SNAPSHOT deployment#248
Conversation
The deploy step in the shared build-backend-module workflow needs MAVEN_REPO_USERNAME and MAVEN_REPO_API_KEY secrets to authenticate with the OpenMRS Maven snapshot repository. Explicitly pass only the three required secrets (NVD_API_KEY, MAVEN_REPO_USERNAME, MAVEN_REPO_API_KEY) to follow the convention used by other OpenMRS modules like webservices.rest and emrapi. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dkayiwa
force-pushed
the
fix/pass-secrets-to-reusable-workflow
branch
from
6b2917e to
2986258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI build (run #497) fails during the Maven deploy step with a 401 Unauthorized error because
MAVEN_REPO_USERNAMEandMAVEN_REPO_API_KEYare empty.The reusable workflow
build-backend-module.ymlexpects these secrets to authenticate with the OpenMRS Maven snapshot repository, butmaven.ymlwas not forwarding any secrets.Fix
Add
secrets: inheritto pass organization-level secrets to the reusable workflow.