- 
                Notifications
    You must be signed in to change notification settings 
- Fork 40
Update troubleshooting.mdx to include common causes of inflated build size #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            SelfhostedPro
  wants to merge
  1
  commit into
  opennextjs:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
SelfhostedPro:patch-1
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
  File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be great to expand here and probably ref some solutions?
i.e.
What do you mean by "metadata"?
What are "Assets located outside of the public directory"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata: I had an icon.png and apple-icon.png that I had followed those docs for and they added almost half a meg and put me over the 3mb limit.
Assets: I’ve dealt with using raw-loader to include files in build before (ie. Custom shaders) and while they aren’t as large, they’re not assets and so would be bundled with the code.
Definitely open to more suggestions for things to add but those are the main ones I ran into/thought of.
Wording could definitely be better on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 remarks:
My first question was more if we need "Metadata" in "Metadata Icons"?
We should find a way to move the image to the asset so that they don't count towards the code size limit.
Could you open an issue on the adapter repo with a minimal repro?
Here I think it's important to mention "raw loader" because that's the source of the pb.
For your own problem, maybe it's possible to fetch them from the assets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll open reproduction in the morning. It’s an open source site so the commit that initially caused the issue for the icons is here:
SelfhostedPro/AdaptAxe-Site@d942873
I don’t need raw-loader in my current project but thought it would be good to include if others run into it.