Fix and enhancement for Next 16

[conico974]

Should fix most build failures in Next 16.
Support for incremental prefetching (Fix #1022)
Support for incremental prefetching in the cache interceptor
Fix #1026

[changeset-bot]

🦋 Changeset detected

Latest commit: d017a4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@opennextjs/aws	Minor
app-pages-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@1029

commit: d017a4a

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	28.05%	2855 / 10178
🔵	Statements	28.05%	2855 / 10178
🔵	Functions	52.46%	149 / 284
🔵	Branches	76.19%	717 / 941

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/adapters/cache.ts	84.82%	83.73%	100%	84.82%	22-23, 87-95, 151-171, 193-194, 379-387, 421-422, 456-465, 475-483
packages/open-next/src/adapters/plugins/image-optimization/image-optimization.replacement.ts	0%	0%	0%	0%	1-49
packages/open-next/src/build/copyTracedFiles.ts	8.1%	100%	25%	8.1%	60-64, 76-399
packages/open-next/src/build/createAssets.ts	0%	0%	0%	0%	1-298
packages/open-next/src/core/routing/cacheInterceptor.ts	79.79%	71.83%	85.71%	79.79%	52, 63-69, 83-84, 109-135, 151-154, 164-167, 222-223, 244-246, 251-252, 263-265, 275-276, 357-358
packages/open-next/src/types/overrides.ts	0%	0%	0%	0%

Generated in workflow #1611 for commit d017a4a by the Vitest Coverage Report Action

[khuezy]

Do we have to handle the middleware => proxy renaming in 16?

[conico974]

Do we have to handle the middleware => proxy renaming in 16?

Nope it doesn't change the name of the compiled file, but we have to update to Node 20 for e2e it seems....

[sommeeeer]

Is this necessary? If so do an expect-error with description.

[vicb]

Looks like it's related to #1026 (the signature changed with Next 16).
+1 to add a comment about that

[sommeeeer]

Why did you set this?

[conico974]

Next does not automatically set the cache on this anymore. Need to test with next start

[sommeeeer]

Very good job Nico! It seems to pass the E2E locally for me on Next 16.

Just a few comments and also could you rename the middleware files to proxy in all the examples app. (npx @next/codemod@canary middleware-to-proxy .)

To make the E2E work both locally and deployed we need to change this to 20:

opennextjs-aws/.github/actions/setup/action.yml

Line 6 in 9b7f726

default: 18.x

And all the Runtime.NODEJS_18_X into Runtime.NODEJS_20_X in OpenNextReferenceImplementation.ts.
Also update package.json here:

opennextjs-aws/package.json

Line 28 in 9b7f726

"node": ">=18",

Perhaps remove these lines as we already setup node and pnpm cache in the setup/action.yml :

opennextjs-aws/.github/workflows/e2e.yml

Lines 95 to 99 in 9b7f726

	- name: Set up NodeJS v18
	uses: actions/setup-node@v4
	with:
	cache: pnpm # cache pnpm store
	node-version: 18.18.2

However, we might do this in a seperate PR. Up to you.

[vicb]

Suggested change

	cacheFileMeta &&
	Array.isArray(cacheFileMeta.segmentPaths) &&
	Array.isArray(cacheFileMeta?.segmentPaths) &&

[vicb]

cacheFileMeta.segmentPaths.length > 0 could also be skipped maybe

[vicb]

Maybe something like:

const segments: Record<string, string> = Array.isArray(cacheFileMeta?.segmentPaths) ? 
  Object.fromEntries(cacheFileMeta.segmentPaths.map(...)) :
  {};