fix: swap width and height to correct default dimensions#21
fix: swap width and height to correct default dimensions#21Qetesh wants to merge 1 commit intoopenobserve:mainfrom
Conversation
|
Hi @Qetesh , I think generally the chrome view port width is bigger than the viewport height on most laptops/monitors. I guess you wanted to mean pdf print page width and height? I added new env variables in the last pr, to add custom values for pdf page width and height (default values are given below, unit is inches) - |
|
Thank you for the explanation! My change was only to correct the swapped width and height naming to keep them consistent. |
|
Hey @Qetesh , sorry I think I missed that part of your pr. Yeah, you are right. The width and height of the headless chromium is swapped. However, I think we don't need to swap the default values of width and height in the ENV variables. There is a problem in the main branch currently where the browser rendering for print mode is kinda buggy (the dashboard panels overlap each other in the reports). As we checked, the chrome width |
|
Hey @Subhra264 ,I completely agree with your approach. For my own setup, I use 1920×1500 and switched the ReportType to PNG — it displays better in terms of width and fits nicely with my macOS Mail client. |
|
Closing this, in favour of #23. Thank you for the contribution! |
No description provided.