PHP_CodeSnifferで使用するルールセットに対する複数の修正 (refs #4002, #4004)#369
Open
upsilon wants to merge 4 commits intoopenpne:old-masterfrom
Open
PHP_CodeSnifferで使用するルールセットに対する複数の修正 (refs #4002, #4004)#369upsilon wants to merge 4 commits intoopenpne:old-masterfrom
upsilon wants to merge 4 commits intoopenpne:old-masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
下記チケットに対する修正です。
Enhancement (機能追加・改善) #4002: コーディング規約違反のチェックが継続的におこなえるように体制を整える
https://redmine.openpne.jp/issues/4002
Enhancement (機能追加・改善) #4004: PHP_CodeSniffer 最新版で動作するようにする
https://redmine.openpne.jp/issues/4004
また、master ブランチに含まれている 9d70ae3 について、対応する下記チケットの対応が不要と判断されたための Revert コミットを含んでいます。
Bug (バグ) #2503: コーディング規約チェックのルールにおいて制御構造のブロックで空白が考慮されていない
https://redmine.openpne.jp/issues/2503