Conversation
When user.home resolves to a relative or invalid path (e.g. "?" on JDK 8-18 in containers without a /etc/passwd entry for the running UID), FileStoreAttributes.saveToConfig() creates a config file inside the working directory. This pollutes the repository working tree, and the file ends up in the LST manifest. On Windows, the "?" character is illegal in paths, causing InvalidPathException when processing the LST. The in-memory FileStoreAttributes cache is sufficient for the lifetime of a JVM process. The only cost of not persisting is re-measuring filesystem timestamp resolution on the next JVM start, which is fast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Problem
FileStoreAttributes.saveToConfig()persists filesystem timestamp resolution measurements to the JGit config file (~/.config/jgit/config). Whenuser.homeresolves to a relative or invalid path (e.g."?"on JDK 8-18 in containers without a/etc/passwdentry for the running UID — see JDK-8280357), this creates a config file inside the repository working directory. The file then gets picked up during working tree traversal and included in build outputs.On Windows, the
?character is illegal in file paths, so processing these build outputs fails withInvalidPathException.Solution
Make
saveToConfig()a no-op. The in-memoryFileStoreAttributescache is sufficient for the lifetime of a JVM process. The only cost is re-measuring filesystem timestamp resolution on the next JVM start, which is fast. This eliminates the possibility of JGit polluting the working tree regardless of whatuser.homeresolves to.