RemoveRedundantFeatureFlags should retain new ObjectMapper() at start of chain#87
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Feb 25, 2026
Conversation
When configure/enable/disable is chained on new ObjectMapper(), the select is J.NewClass not J.MethodInvocation. Treat both as chain and return the select so the expression becomes 'new ObjectMapper()' instead of being removed (which left 'return;'). Also renames test to removeConfigureChainedOnNewObjectMapper. Co-authored-by: Cursor <cursoragent@cursor.com>
timtebeek
approved these changes
Feb 25, 2026
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Thanks a lot for the immediate fix!
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Contributor
Author
|
Looked like my autoformat broke the test and I didn't notice it. Fixed that. |
timtebeek
changed the title
RemoveRedundantFeatureFlags should retain new ObjectMapper() at start of chain
Member
|
Perfect, thanks a lot for the quick rework. Should go out with the next release in ~2 weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
When configure/enable/disable is chained on new ObjectMapper(), the select is J.NewClass not J.MethodInvocation. Treat both as chain and return the select so the expression becomes 'new ObjectMapper()' instead of being removed (which left 'return;').
What's your motivation?
Fixes an issue I discovered while running rewrite on my projects
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
I did not see any potential workaround to this aside from manually fixing the places it incorrectly removed code.
Any additional context
Checklist