Add typeParameters to generic descriptors and always serialize parameters#8
Merged
knutwannheden merged 2 commits intomainfrom Feb 23, 2026
Merged
Add typeParameters to generic descriptors and always serialize parameters#8knutwannheden merged 2 commits intomainfrom
knutwannheden merged 2 commits intomainfrom
Conversation
…tors
Surface generic type parameters (PEP 695) in the wire protocol. Extracts
type parameters from Signature.generic_context and ClassLiteral.generic_context,
filtering out implicit Self type variables. Also fixes TypeVar name to use the
simple name (e.g. "T") instead of the qualified display form ("T@identity").
…tors A function declaration should always include a parameters array, even when empty, so consumers don't need to handle the absent-key case.
knutwannheden
force-pushed
the
wonky-koala
branch
from
d129b4b to
d772113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeParametersfield toFunction,ClassLiteral, andBoundMethoddescriptors, surfacing PEP 695 generic type parameters in the wire protocolSignature.generic_contextandClassLiteral.generic_context, filtering out implicitSelftype variablesTypeVarname to use the simple name (e.g.T) instead of the qualified display form (T@identity)parametersonFunctionandBoundMethod(even when empty)Test plan
test_generic_function_type_parameters— verifiesdef identity[T](x: T) -> ThastypeParameterspointing to atypeVarnamedTtest_generic_class_type_parameters— verifiesclass Box[T]hastypeParametersonclassLiteraltest_non_generic_function_no_type_parameters— verifies non-generic function omitstypeParameterskey