Replace ide_support with direct call binding; add typeArguments#9
Merged
knutwannheden merged 4 commits intomainfrom Feb 23, 2026
Merged
Replace ide_support with direct call binding; add typeArguments#9knutwannheden merged 4 commits intomainfrom
knutwannheden merged 4 commits intomainfrom
Conversation
…tors
Surface generic type parameters (PEP 695) in the wire protocol. Extracts
type parameters from Signature.generic_context and ClassLiteral.generic_context,
filtering out implicit Self type variables. Also fixes TypeVar name to use the
simple name (e.g. "T") instead of the qualified display form ("T@identity").
…tors A function declaration should always include a parameters array, even when empty, so consumers don't need to handle the absent-key case.
Replace the ide_support call_signature_details API with direct use of ty's binding APIs (Type::bindings, match_parameters, check_types_impl). This gives access to Binding::specialization(), which we use to: - Resolve TypeVar parameters to their concrete types inline - Surface inferred type arguments on CallSignatureInfo
# Conflicts: # ruff # tests/integration/main.rs
knutwannheden
force-pushed
the
wonky-koala
branch
from
c4f4b24 to
c738c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ide_support::call_signature_detailswith direct use of ty's binding APIs (Type::bindings(),match_parameters(),check_types_impl())Specializationfrom call bindings to resolve TypeVar parameters to concrete types and surface inferred type arguments inCallSignatureInfofnandmoddeclarationsTest plan
test_generic_call_type_argumentsverifiesidentity(42)surfaces onetypeArgumentsentrycargo checkclean