Use ubuntu-latest runner images for tests
#116
Conversation
We were on `ubuntu-20.04` which is no longer supported.
| jobs: | ||
| test-action: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
thought: We could specify ubuntu-24.04 which is the same thing right now instead of ubuntu-latest; I don't have strong opinions though:
ubuntu-latestmeans you shouldn't need to change this again, unless there's some sudden incompatibility with a new version.ubuntu-24.04means nothing changes without you knowing.
There was a problem hiding this comment.
I think for something simple and infrequently updated like this, the benefits of not having to update it again outweigh the benefits of keeping the version deterministic.
I think we might make different calls for other repos though.
evansd
left a comment
evansd
left a comment
There was a problem hiding this comment.
Great, thanks for sorting this – and realising what the problem was in the first place!
| jobs: | ||
| test-action: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I think for something simple and infrequently updated like this, the benefits of not having to update it again outweigh the benefits of keeping the version deterministic.
I think we might make different calls for other repos though.
We were on
ubuntu-20.04which is no longer supported.