Ignore some errors when checking links #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying opensafely-docs with
|
| Latest commit: |
01983db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6cbcf75e.opensafely-docs.pages.dev |
| Branch Preview URL: | https://ignore-some-check-links-erro.opensafely-docs.pages.dev |
We are currently seeing the link checking workflow fail on transient errors. So we should tell lychee to accept a wider range of responses, such as server errors and timeouts, as these don't indicate a broken link, but are instead temporary issues that we don't need to act upon.
lucyb
force-pushed
the
ignore-some-check-links-errors
branch
from
896ecd9 to
01983db
Compare
StevenMaude
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently seeing the link checking workflow fail on transient errors. So we should tell lychee to accept a wider range of responses, such as server errors and timeouts, as these don't indicate a broken link, but are instead temporary issues that we don't need to act upon.
I've made a "successful" run to demonstrate that the change has worked. It's failed on a 40x status code, but that's expected behaviour.