Add max rpcs to parallel strategy #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a configurable limit for maximum RPCs used in parallel strategy and fixes WSS URL handling in the ChainList integration. These changes improve performance and prevent connection errors when users add multiple RPC endpoints.
Changes
1. Maximum RPC Limit for Parallel Strategy
Added new setting (maxRPCsToUse) that limits how many RPC endpoints are queried simultaneously when using the parallel RPC strategy:
Default: 3 RPCs (configurable in Settings)
Location: settings/index.tsx:130-136
Implementation: RPCClient.ts now respects this limit when executing parallel calls
Benefits:
2. WSS URL Filtering
Fixed issue where WebSocket URLs (wss://) from ChainList were causing connection errors:
Change: Filter out WSS URLs when fetching RPCs from ChainList
Location: settings/index.tsx:301
Rationale: OpenScan uses HTTP(S) JSON-RPC, not WebSocket connections
Impact:
UI Changes
Added new "Max RPCs to Use" slider in Settings page:
Default: 3
Only visible/applicable when parallel RPC strategy is enabled
Breaking Changes
None - This is a backward-compatible enhancement with sensible defaults.