(INF-2871) Fix COmanage API request back-off in scripts.#26
Merged
brianhlin merged 3 commits intoopensciencegrid:masterfrom Mar 11, 2025
Merged
Conversation
Fix exponential backoff to also apply to wait times between making requests, and not just timeouts on the requests themselves. Also improve error messages to include more information about how the request went / why it failed.
brianhlin
requested changes
Mar 6, 2025
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
See requested changes in-line. I don't think we need to explicitly set StandardOutput=journal as that's the default
williamnswanson
force-pushed
the
INF-2871.backoff-fix
branch
from
6747fd3 to
e51ac88
Compare
williamnswanson
force-pushed
the
INF-2871.backoff-fix
branch
from
e51ac88 to
820d978
Compare
brianhlin
reviewed
Mar 10, 2025
brianhlin
approved these changes
Mar 11, 2025
Member
brianhlin
left a comment
brianhlin
left a comment
There was a problem hiding this comment.
LGTM, pylint test failures are unrelated to these changes so I'll override to merge.
@williamnswanson in the future, I'd like to see more informative commit messages that adhere to https://osg-htc.org/technology/software/git-software-development/#put-logically-separate-changes-into-separate-commits. I would have liked to see a collection of different commits explaining the what / why of each change rather than blanket "address PR feedback" commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix exponential back-off to also apply to wait times between making requests, and not just timeouts on the requests themselves. Also improve error messages to include more information about how the request went / why it failed.
For the Stdout logs to make their way to the journal when scripts are being run as a systemd service, I believe we may need to add
StandardOutput=journalto the service description?