Fix NPE when nested field type has no properties in doc-level monitor#2049
Merged
AWSHurneyt merged 1 commit intoopensearch-project:mainfrom Mar 21, 2026
Merged
Conversation
A nested field with type 'nested' but no sub-properties causes a NullPointerException during doc-level monitor creation. The traverseMappingsAndUpdate method assumes all non-leaf nodes have a 'properties' map, but nested fields without sub-properties have none. Added a null guard before recursing into nested field properties. Fields with type 'nested' and no properties are now safely skipped. Resolves opensearch-project/security-analytics#1472 Signed-off-by: Manaswini Ragamouni <manaswini1920@gmail.com> Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt
approved these changes
Mar 20, 2026
engechas
approved these changes
Mar 20, 2026
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.18 2.18
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.18
# Create a new branch
git switch --create backport-2049-to-2.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b31fabfced6ece17d80b0891b2cec98d9e9e163
# Push it to GitHub
git push --set-upstream origin backport-2049-to-2.18
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.18Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.19
# Create a new branch
git switch --create backport-2049-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b31fabfced6ece17d80b0891b2cec98d9e9e163
# Push it to GitHub
git push --set-upstream origin backport-2049-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.19Then, create a pull request where the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A nested field with type nested but no sub-properties (e.g. "http_request_headers": {"type": "nested"}) causes a NullPointerException during doc-level monitor creation.
In DocLevelMonitorQueries.traverseMappingsAndUpdate(), the code assumes all non-leaf nodes have a properties map. When a field has type: "nested", it's treated as an internal node and the code unconditionally
casts nodeProps["properties"] to MutableMap<String, Any>. If the nested field has no sub-properties, this is null, causing the crash.
Fix: Added a null guard before recursing into nested field properties. Fields with type: "nested" and no properties are now safely skipped during traversal.
Testing: Added unit tests to AlertingUtilsTests covering both cases:
Related Issues
Resolves opensearch-project/security-analytics#1472
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/alerting/blob/main/CONTRIBUTING.md#developer-certificate-of
-origin).