Skip to content

Inject SdkClient into transport actions for SDK persistence support#2052

Merged
riysaxen-amzn merged 2 commits intoopensearch-project:mainfrom
manaswini1920:feature/workspace-datasource-support
Mar 25, 2026
Merged

Inject SdkClient into transport actions for SDK persistence support#2052
riysaxen-amzn merged 2 commits intoopensearch-project:mainfrom
manaswini1920:feature/workspace-datasource-support

Conversation

@manaswini1920
Copy link
Contributor

Description

Inject SdkClient into transport actions for SDK persistence support.

  • Add SdkClient as a constructor parameter to all 13 transport actions that perform persistence operations
  • SdkClient is created by AlertingPlugin (Aghil's PR [FEATURE] Integrate remote metadata SDK client with alerting plugin (#2046) #2047) and injected via Guice
  • This wiring enables transport actions to use the Remote Metadata SDK for storage routing in a future change
  • No behavioral changes — SdkClient is injected but not yet used

Related Issues

Depends on #2047

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@engechas engechas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check on the failing CIs?

@manaswini1920 manaswini1920 force-pushed the feature/workspace-datasource-support branch from 37c8f72 to 8e7a895 Compare March 24, 2026 21:56
@manaswini1920
Copy link
Contributor Author

Could you check on the failing CIs?

Fixed the CI — added missing force declarations for jackson-dataformat-smile and jackson-dataformat-yaml in build.gradle. This was a pre-existing dependency conflict from the 3.6.0-SNAPSHOT version bump.

@manaswini1920 manaswini1920 force-pushed the feature/workspace-datasource-support branch from 8e7a895 to 5f8545e Compare March 24, 2026 22:12
Add SdkClient as a constructor parameter to all transport actions that
perform persistence operations. SdkClient is created by AlertingPlugin
and injected via Guice. This wiring enables transport actions to use
the Remote Metadata SDK for storage routing in a future change.

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
@manaswini1920 manaswini1920 force-pushed the feature/workspace-datasource-support branch from 5f8545e to cb32b7e Compare March 24, 2026 23:28
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
@riysaxen-amzn riysaxen-amzn merged commit 551e26e into opensearch-project:main Mar 25, 2026
19 of 20 checks passed
manaswini1920 pushed a commit to manaswini1920/alerting that referenced this pull request Mar 25, 2026
@manaswini1920 manaswini1920 mentioned this pull request Mar 25, 2026
1 task
manaswini1920 pushed a commit to manaswini1920/alerting that referenced this pull request Mar 25, 2026
…upport (opensearch-project#2052)"

This reverts commit 551e26e.

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt pushed a commit that referenced this pull request Mar 25, 2026
* Revert "Inject SdkClient into transport actions for SDK persistence support (#2052)"

This reverts commit 551e26e.

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>

* Revert "feat: Integrate remote metadata SDK client with alerting plugin (#2046) (#2047)"

This reverts commit 7fae816.

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>

---------

Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
Co-authored-by: Manaswini Ragamouni <ragamanu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants