FEATURE: Summarize the steps when max steps limit reached #4416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…roject#4331)" This reverts commit fb90b1b.
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…Agents (opensearch-project#4397) * add hooks in ml-commons (opensearch-project#4326) Signed-off-by: Xun Zhang <xunzh@amazon.com> * initiate context management api with hook implementation (opensearch-project#4345) * initiate context management api with hook implementation Signed-off-by: Mingshi Liu <mingshl@amazon.com> * apply spotless Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> * Add Context Manager to PER (opensearch-project#4379) * add pre_llm hook to per agent Signed-off-by: Mingshi Liu <mingshl@amazon.com> change context management passing from query parameters to payload Signed-off-by: Mingshi Liu <mingshl@amazon.com> pass hook registery into PER Signed-off-by: Mingshi Liu <mingshl@amazon.com> apply spotless Signed-off-by: Mingshi Liu <mingshl@amazon.com> initiate context management api with hook implementation Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add comment Signed-off-by: Mingshi Liu <mingshl@amazon.com> * format Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add validation Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add inner create context management to agent register api Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add code coverage Signed-off-by: Mingshi Liu <mingshl@amazon.com> * allow context management hook register in during agent execute Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add code coverage Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add more code coverage Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add validation check Signed-off-by: Mingshi Liu <mingshl@amazon.com> * adapt to inplace update for context Signed-off-by: Mingshi Liu <mingshl@amazon.com> * fix test Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Xun Zhang <xunzh@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> Co-authored-by: Xun Zhang <xunzh@amazon.com>
…ut atm) Signed-off-by: Pavan Yekbote <pybot@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
…ing in index (opensearch-project#4403) * allow inline create context management without storing in agent register Signed-off-by: Mingshi Liu <mingshl@amazon.com> * make ML_COMMONS_MULTI_TENANCY_ENABLED default is false Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
…#4407) Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
…roject#4408) * Fix POST_TOOL hook interaction updates and add tenant ID support Signed-off-by: Mingshi Liu <mingshl@amazon.com> - Fix POST_TOOL hook to return full ContextManagerContext like PRE_LLM hook - Update MLChatAgentRunner to properly handle interaction updates from POST_TOOL hook - Ensure interactions list and tmpParameters.INTERACTIONS stay synchronized - Add tenant ID support to MLPredictionTaskRequest in ModelGuardrail and SummarizationManager Signed-off-by: Mingshi Liu <mingshl@amazon.com> * fix error message escaping Signed-off-by: Mingshi Liu <mingshl@amazon.com> * consolicate post_hook logic Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com>
PauiC
requested review from
HenryL27,
Zhangxunmt,
austintlee,
pyek-bot,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
PauiC
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
PauiC
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
PauiC
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
PauiC
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
Hailong-am
approved these changes
Nov 12, 2025
Contributor
Hailong-am
left a comment
Hailong-am
left a comment
There was a problem hiding this comment.
cherry picked from original PR
5 tasks
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
Signed-off-by: Jiaru Jiang <jiaruj@amazon.com>
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
PauiC
requested a deployment
to
ml-commons-cicd-env-require-approval
GitHub Actions
Waiting
pyek-bot
reviewed
Nov 14, 2025
| } | ||
| } | ||
|
|
||
| public String extractSummaryFromResponse(MLTaskResponse response) { |
Collaborator
There was a problem hiding this comment.
try to avoid returning nulls inside methods, ideally this method would also handle the errors and return a fallback response.
If you return nulls in a method, it requires the caller to handle the null which can potentially lead to NPEs.
Not urgent, can address in future PRs
pyek-bot
reviewed
Nov 14, 2025
| }, finalListener::onFailure); | ||
|
|
||
| generateSummary(llm, completedSteps, allParams.get(TENANT_ID_FIELD), ActionListener.wrap(summary -> { | ||
| log.info("Summary generated successfully"); |
Collaborator
There was a problem hiding this comment.
let's remove this log, seems redundant
pyek-bot
reviewed
Nov 14, 2025
Comment on lines
+779
to
+789
| String fallbackResult = completedSteps.isEmpty() || completedSteps.size() < 2 | ||
| ? String.format("Max Steps Limit (%d) Reached. Use memory_id with same task to restart.", maxSteps) | ||
| : String | ||
| .format( | ||
| "Max Steps Limit (%d) Reached. Use memory_id with same task to restart. \n " | ||
| + "Last executed step: %s, \n " | ||
| + "Last executed step result: %s", | ||
| maxSteps, | ||
| completedSteps.get(completedSteps.size() - 2), | ||
| completedSteps.getLast() | ||
| ); |
Collaborator
There was a problem hiding this comment.
you can pass the fallback from the previous method which is generated, this can make the current method more reusable
it's fine for now!
pyek-bot
reviewed
Nov 14, 2025
| } | ||
| } | ||
|
|
||
| private String extractSummaryFromResponse(MLTaskResponse response) { |
Collaborator
There was a problem hiding this comment.
you can move this to agent utils in a later PR
pyek-bot
approved these changes
Nov 14, 2025
Collaborator
pyek-bot
left a comment
pyek-bot
left a comment
There was a problem hiding this comment.
LGTM, let's merge and address the comments in the main branch PR (or in a follow up PR)
Thanks for taking this up!
pyek-bot
force-pushed
the
feature/agentic_memory_integration
branch
from
ce7f3f5 to
cd738fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature provides intelligent summarization when ML Commons Chat Agents and PER (planner) agent reach their maximum iteration limit without completing tasks.
Related Issues
#4150
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.