Merge Flaky Test Partial Progress#300
Draft
ajleong623 wants to merge 1 commit intoopensearch-project:mainfrom
Draft
Merge Flaky Test Partial Progress#300ajleong623 wants to merge 1 commit intoopensearch-project:mainfrom
ajleong623 wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change shows where I placed the logs to record key data structures in the
JVectorWriter. I noticed that when docs "disappear", the segments are actually still have all the documents. I verified this by using the match-all query instead of theJVectorKnnFloatVectorQueryand checked if all the documents are in the index. Therefore, the search path can be investigated more and why the reader does not read all the documents.Related Issues
#281
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.