Skip to content

Temporarily removed visualizations for 3.0-alpha1.#1272

Merged
peterzhuamazon merged 3 commits intoopensearch-project:mainfrom
AWSHurneyt:main-3.0-alpha1-vega
Mar 16, 2025
Merged

Temporarily removed visualizations for 3.0-alpha1.#1272
peterzhuamazon merged 3 commits intoopensearch-project:mainfrom
AWSHurneyt:main-3.0-alpha1-vega

Conversation

@AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Mar 15, 2025

Description

Refactored vega-based visualizations to chart.js.
Removed visualizations from the plugin. The chart.js assets are causing the following error when running the plugin on a docker image.

ReferenceError: exports is not defined
    <anonymous> http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.chunk.0.js:7
    __webpack_require__ http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1
    <anonymous> http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.chunk.0.js:25
    <anonymous> http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.chunk.0.js:25
    __webpack_require__ http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1
    1006 http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.chunk.1.js:1
    __webpack_require__ http://localhost:5601/8336/bundles/plugin/securityAnalyticsDashboards/securityAnalyticsDashboards.plugin.js:1

Issues Resolved

#1185

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Collaborator Author

The cypress test workflow will likely fail. PR #1269 is intended to fix the workflow configuration, but is still a work in progress. Will run the cypress tests locally, and post the output.

…to distribution.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt changed the title Refactored vega-based visualizations to chart.js. Removed visualizations for 3.0-alpha1. Mar 16, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Collaborator Author

Used yarn build to construct a zip file of the plugin, and manually confirmed it ran successfully in a docker cluster following the removal of these assets.

@peterzhuamazon peterzhuamazon merged commit b405703 into opensearch-project:main Mar 16, 2025
6 of 8 checks passed
@AWSHurneyt AWSHurneyt changed the title Removed visualizations for 3.0-alpha1. Temporarily removed visualizations for 3.0-alpha1. Mar 17, 2025
vikhy-aws pushed a commit to vikhy-aws/security-analytics-dashboards-plugin that referenced this pull request Nov 4, 2025
* Refactored vega-based visualizations to chart.js.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Removed visualizations as chart.js dependency is also not building into distribution.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
vikhy-aws pushed a commit to vikhy-aws/security-analytics-dashboards-plugin that referenced this pull request Nov 4, 2025
* Refactored vega-based visualizations to chart.js.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Removed visualizations as chart.js dependency is also not building into distribution.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Updated snapshots.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants