Skip to content

Fixes saml login flow to work with anonymous auth#1839

Merged
derek-ho merged 33 commits intoopensearch-project:mainfrom
DarshitChanpura:fixes-saml-login-flow
Apr 12, 2024
Merged

Fixes saml login flow to work with anonymous auth#1839
derek-ho merged 33 commits intoopensearch-project:mainfrom
DarshitChanpura:fixes-saml-login-flow

Conversation

@DarshitChanpura
Copy link
Copy Markdown
Member

@DarshitChanpura DarshitChanpura commented Mar 21, 2024

Description

This PR fixes 2 things:

  1. Anonymous login button would not show if only 1 auth option was supplied
  2. Broken SAML auth flow when anonymous auth is enabled.
  3. Automatic login as anonymous user upon SAML user logout. (Discovered while fixing this bug)

Category

  • Bug fix

Why these changes are required?

  • For SAML and anonymous auth options to function when both options are enabled
  • To prevent auto login as anonymous user upon SAML user logout

What is the old behavior before changes and new behavior after changes?

  • At present, SAML auth flow is broken since anonymous auth automatically assumes the Anonymous user when no auth credentials are found. See security plugin PR[1] for more details.

[1] - Companion PR: opensearch-project/security#4152

Issues Resolved

Testing

  • Automated + Manual

Manual testing:

Screen.Recording.2024-04-11.at.11.55.53.AM.mov

Check List

  • New functionality includes testing
    - [ ] New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x backport to 2.x branch

Projects

None yet

4 participants