Make opensearch_security.multitenancy.tenants.preferred configurable dynamically via security config api#5986
Open
itsmevichu wants to merge 8 commits intoopensearch-project:mainfrom
Open
Conversation
…nfo API Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
Member
|
@itsmevichu thank you for this PR. Can you please fix the CHANGELOG conflict? Apologies for not running the checks earlier. They are running now. Please look for any failures if some of the checks come back red. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5986 +/- ##
==========================================
+ Coverage 73.82% 73.91% +0.08%
==========================================
Files 439 439
Lines 27087 27130 +43
Branches 4018 4021 +3
==========================================
+ Hits 19998 20053 +55
+ Misses 5180 5173 -7
+ Partials 1909 1904 -5
🚀 New features to boost your workflow:
|
Signed-off-by: Vishnutheep B <vishnutheep@gmail.com>
6dc4f6f to
8f12076
Compare
Author
|
The failing CI checks seems irrelevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes making
opensearch_security.multitenancy.tenants.preferredconfigurable dynamically via the Security configuration API in OpenSearch, instead of being solely controlled via opensearch_dashboards.ymlBefore:
preferred_tenantswas not part of config APIs or/dashboardsinfo.After:
preferred_tenantscan be set via tenancy config API, is persisted inConfigV7.Kibana, returned in/dashboardsinfo.Issues Resolved
#5969
Testing
MultiTenancyConfigApiTestandConfigV7Testforpreferred_tenants. :Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.