Skip to content

Commit before closing Store #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdhsl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Commit before closing Store #191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e0a18
Commit before closing Store
mdhsl Apr 1, 2026
5bcfb63
Move close into doStop instead of beforeStop
mdhsl Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions ...src/main/java/org/sensorhub/impl/datastore/postgis/database/PostgisObsSystemDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,12 @@ protected void afterStart() {
}


protected void closeStore() {

}

@Override
protected void beforeStop() {
protected void doStop() throws SensorHubException {
Copy link
Copy Markdown
Member

@alexrobin alexrobin Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you have to call commit in the close method of the stores?

// Try to close every store separately
try {
obsStore.close();
Expand Down Expand Up @@ -172,14 +176,6 @@ protected void beforeStop() {
}
}

protected void closeStore() {

}

@Override
protected void doStop() throws SensorHubException {
}


@Override
public Integer getDatabaseNum() {
Expand Down
Loading