ART-12444- changes in ocp4-konflux #2279
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughAdded async method Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyartcd/pyartcd/pipelines/ocp4_konflux.py (1)
428-448: Verify whether assembly check should be added for consistency.The new method follows the established pattern well and integrates cleanly with the existing error handling and dry-run logic. However, both
sweep_bugs()(lines 376-378) andsweep_golang_bugs()(lines 402-404) include an assembly check that skips execution whenself.assembly != 'stream'. This method lacks that check.If second-fix bug sweeps should run for all assemblies (not just stream), please add a comment explaining why this method differs from the others. Otherwise, consider adding the assembly check for consistency:
async def sweep_second_fix_bugs(self): # find-bugs:second-fix closes CVE trackers that are not first-fix in pre-release branches # The command itself checks the software lifecycle phase and only runs for pre-release/signing phases + if self.assembly != 'stream': + self.runtime.logger.info('Not closing second-fix bugs since assembly is not stream') + return + cmd = [ 'elliott', f'--group=openshift-{self.version}', "find-bugs:second-fix", "--close", ]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
pyartcd/pyartcd/pipelines/ocp4_konflux.py(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
pyartcd/pyartcd/pipelines/ocp4_konflux.py (2)
artcommon/artcommonlib/exectools.py (1)
cmd_assert_async(637-705)pyartcd/pyartcd/slack.py (2)
bind_channel(34-50)say(60-97)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: tests
🔇 Additional comments (1)
pyartcd/pyartcd/pipelines/ocp4_konflux.py (1)
729-729: LGTM! Integration follows the established sweep sequence.The method is appropriately placed after the other bug sweep operations and within the version check, ensuring it only runs for versions in
KONFLUX_IMAGESTREAM_OVERRIDE_VERSIONS.
|
@mbiarnes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| if self.runtime.dry_run: | ||
| return | ||
| self.slack_client.bind_channel(f'openshift-{self.version}') | ||
| await self.slack_client.say(f'Second-fix bug sweep failed for {self.version}. Please investigate') | ||
|
|
There was a problem hiding this comment.
| if self.runtime.dry_run: | |
| return | |
| self.slack_client.bind_channel(f'openshift-{self.version}') | |
| await self.slack_client.say(f'Second-fix bug sweep failed for {self.version}. Please investigate') | |
| message = f'Second-fix bug sweep failed for {self.version}. Please investigate' | |
| LOGGER.warning(message) | |
| if not self.runtime.dry_run: | |
| self.slack_client.bind_channel(f'openshift-{self.version}') | |
| await self.slack_client.say() |
2 participants
for find-bugs:second-fix
which closes OCPBUGS that are found/determined as not first-fix when running ocp4_konflux jobs - only and when the software-lifecycle phase is pre-release or signed (so before release)
test-job:
https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/hack/job/mbiarnes/job/ocp4-konflux/49/console