allow namespace changes prior to content publishing#490
allow namespace changes prior to content publishing#490komish merged 1 commit intoopenshift-helm-charts:mainfrom
Conversation
It is now technically possible for a partner to change their vendor_label, now referred to as namespace, so long as they have no published content. The operation in-repo is submitted by redhat-mercury-bot, and contains a single file with a status of renamed. Renamed files are treated as effectively new files, prompting a lockfile check to gate merging. All pre-existing checks (one file in the change, file, content is being modified) still apply. Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
|
Tests (here) are currently broken, but you can test logs here: This log shows what happens when a file is marked as renamed, but changes the chart's name to one that's already locked This log shows what happens when a file is successfully renamed Disregard the "approve PR" failure - that's a token issue. |
jsm84
left a comment
There was a problem hiding this comment.
LGTM.
I had to look up GHA syntax of ${{ variable && variable || fallback-value}} as it looked like it could be simplified to ${{ variable || fallback-value}} but saw that it was a conditional (like C's condition ? if-true : if-false)
|
@jsm84 Yep, it's effectively the ternary syntax, but to your point in the way it's applied here, the condition could technically be omitted. https://github.com/komish/gh-actions-hackery/actions/runs/21646244246/job/62398886438 In node, It seems non-empty strings are truthy and empty strings are falsey, and so condensing the syntax would produce the same output (as seen above). That said, I'll leave the condition branch for now, as it may change to be more explicit ( |
It is now (or will be soon) technically possible for a partner to change their vendor_label, now referred to as namespace, via the partner dashboard - so long as they have no published content. The operation in-repo is submitted by redhat-mercury-bot, and contains a single file with a status of renamed.
Renamed files are treated as effectively new files, prompting a lockfile check to gate merging.
All pre-existing checks (one file in the change, file, content is being modified) still apply.
Summary: