Skip to content

Comments

allow namespace changes prior to content publishing#490

Merged
komish merged 1 commit intoopenshift-helm-charts:mainfrom
komish:EET-5017-allow-renames
Feb 3, 2026
Merged

allow namespace changes prior to content publishing#490
komish merged 1 commit intoopenshift-helm-charts:mainfrom
komish:EET-5017-allow-renames

Conversation

@komish
Copy link
Contributor

@komish komish commented Jan 30, 2026

It is now (or will be soon) technically possible for a partner to change their vendor_label, now referred to as namespace, via the partner dashboard - so long as they have no published content. The operation in-repo is submitted by redhat-mercury-bot, and contains a single file with a status of renamed.

Renamed files are treated as effectively new files, prompting a lockfile check to gate merging.

All pre-existing checks (one file in the change, file, content is being modified) still apply.

Summary:

  • Check if a file is marked as being "renamed" instead of "added" or "modified"
  • Use that information to run some additional checks on the new OWNERS file to make sure it's safe to merge. Lock checks are still executed.
  • Automatically merge the rename operation.

It is now technically possible for a partner to change their
vendor_label, now referred to as namespace, so long as they have no
published content. The operation in-repo is submitted by
redhat-mercury-bot, and contains a single file with a status of renamed.

Renamed files are treated as effectively new files, prompting a lockfile
check to gate merging.

All pre-existing checks (one file in the change, file, content is being
modified) still apply.

Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
@komish
Copy link
Contributor Author

komish commented Jan 30, 2026

Tests (here) are currently broken, but you can test logs here:

This log shows what happens when a file is marked as renamed, but changes the chart's name to one that's already locked
https://github.com/komish/charts-ci-testbed/actions/runs/21531326335/job/62047680652

This log shows what happens when a file is successfully renamed
https://github.com/komish/charts-ci-testbed/actions/runs/21530065709/job/62043512238

Disregard the "approve PR" failure - that's a token issue.

Copy link
Contributor

@jsm84 jsm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I had to look up GHA syntax of ${{ variable && variable || fallback-value}} as it looked like it could be simplified to ${{ variable || fallback-value}} but saw that it was a conditional (like C's condition ? if-true : if-false)

@komish
Copy link
Contributor Author

komish commented Feb 3, 2026

@jsm84 Yep, it's effectively the ternary syntax, but to your point in the way it's applied here, the condition could technically be omitted.

https://github.com/komish/gh-actions-hackery/actions/runs/21646244246/job/62398886438

In node, It seems non-empty strings are truthy and empty strings are falsey, and so condensing the syntax would produce the same output (as seen above).

That said, I'll leave the condition branch for now, as it may change to be more explicit (!= '') at a future time if this logic becomes troublesome.

@komish komish merged commit 5d042b3 into openshift-helm-charts:main Feb 3, 2026
8 of 13 checks passed
@komish komish deleted the EET-5017-allow-renames branch February 3, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants