ROSAENG-133 - feat: add extraVolumes and extraVolumeMounts support to…

[cdoan1]

… Helm chart

Summary

Adds configuration options to inject custom volumes and volume mounts into the Sentinel deployment, enabling users to mount additional ConfigMaps, Secrets, or other volume types as needed.

Used by the regional team to support aws podidentity

• HYPERFLEET-XXX

Test Plan

• Unit tests added/updated
• make test-all passes
• make lint passes
• Helm chart changes validated with make test-helm (if applicable)
• Deployed to a development cluster and verified (if Helm/config changes)
• E2E tests passed (if cross-component or major changes)

Summary by CodeRabbit

• New Features
  • Added support for injecting custom volumes and volume mounts into Kubernetes deployments via configurable parameters.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @cdoan1. Thanks for your PR.

I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1896b44c-d259-4b95-b168-f4f0d6057214

📥 Commits

Reviewing files that changed from the base of the PR and between 16b49fb and c1b804c.

📒 Files selected for processing (2)

• charts/templates/deployment.yaml
• charts/values.yaml

---

Walkthrough

This pull request adds support for custom volume and volume mount configurations in a Helm chart. The charts/values.yaml file introduces two new empty-array configuration options: extraVolumes and extraVolumes. The charts/templates/deployment.yaml file is updated with conditional rendering blocks that inject these user-defined values into the Kubernetes Deployment spec at spec.template.spec.containers[].volumeMounts and spec.template.spec.volumes respectively. These additions are optional and only render when the corresponding values are provided.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: adding extraVolumes and extraVolumeMounts support to the Helm chart, which aligns with the file modifications in deployment.yaml and values.yaml.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ciaranRoche]

/ok-to-test

[ciaranRoche]

Just one comment inline, not against this change, so added ok-to-test while you confirm its required beyond using the SA annotations.

[ciaranRoche]

Not against adding the extra vol mounts to the vals here, but wondering if SA annotations would solve your pod identity setup?