Skip to content

Conversation

@rebtoor
Copy link

@rebtoor rebtoor commented Nov 6, 2025

  • Enhance retry_with_timeout to support retry delays and exponential backoff via RETRY_DELAY and EXPONENTIAL_BACKOFF environment variables.
  • Add retries to ansible-galaxy role and collection installations to handle transient network errors like HTTP 502.
  • Check requirements.yml existence before proceeding with installation.

@openshift-ci openshift-ci bot requested review from cybertron and mkowalski November 6, 2025 09:56
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

Hi @rebtoor. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fmount
Copy link

fmount commented Nov 18, 2025

+1 thanks @rebtoor

@rebtoor
Copy link
Author

rebtoor commented Nov 18, 2025

@mkowalski @cybertron hi folks, sorry to ping you here... can we at least allow the tests to run? :)

@bfournie
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 18, 2025
@bfournie
Copy link
Contributor

bfournie commented Nov 18, 2025

Looks like hitting
ERROR! Error when getting available collection versions for community.general from default (https://galaxy.ansible.com/api/) (HTTP Code: 500, Message: Internal Server Error Code: Unknown)

@rebtoor
Copy link
Author

rebtoor commented Nov 18, 2025

@bfournie yep, this PR should be a mitigation for transient network issues but this seems a real outage :(

@rebtoor
Copy link
Author

rebtoor commented Nov 18, 2025

❯ for host in $(dig +short galaxy.ansible.com); do echo -ne "${host}\t" ;whois ${host}|grep OrgName;done
172.67.68.251   OrgName:        Cloudflare, Inc.
104.26.0.234    OrgName:        Cloudflare, Inc.
104.26.1.234    OrgName:        Cloudflare, Inc.

ok, i guess we need to wait :)

@rebtoor
Copy link
Author

rebtoor commented Nov 18, 2025

/retest

(it seems cloudflare issues should be solved now)

…alaxy

Enhance retry_with_timeout to support retry delays and exponential backoff
via RETRY_DELAY and EXPONENTIAL_BACKOFF environment variables. Add retries
to ansible-galaxy role and collection installations to handle transient
network errors like HTTP 502. Check requirements.yml existence before
proceeding with installation.

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor rebtoor force-pushed the ansible-galaxy-retries branch from 3f2f106 to 66f87fe Compare November 19, 2025 16:28
@rebtoor
Copy link
Author

rebtoor commented Nov 19, 2025

@bfournie other than the outage there was a problem in my patch. I was calling the the function omitting one required parameter. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants