-
Notifications
You must be signed in to change notification settings - Fork 199
feat(install): add retry logic with exponential backoff for ansible-galaxy #1806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @rebtoor. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
+1 thanks @rebtoor |
|
@mkowalski @cybertron hi folks, sorry to ping you here... can we at least allow the tests to run? :) |
|
/ok-to-test |
|
Looks like hitting |
|
@bfournie yep, this PR should be a mitigation for transient network issues but this seems a real outage :( |
ok, i guess we need to wait :) |
|
/retest (it seems cloudflare issues should be solved now) |
…alaxy Enhance retry_with_timeout to support retry delays and exponential backoff via RETRY_DELAY and EXPONENTIAL_BACKOFF environment variables. Add retries to ansible-galaxy role and collection installations to handle transient network errors like HTTP 502. Check requirements.yml existence before proceeding with installation. Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
3f2f106 to
66f87fe
Compare
|
@bfournie other than the outage there was a problem in my patch. I was calling the the function omitting one required parameter. :) |
retry_with_timeoutto support retry delays and exponential backoff viaRETRY_DELAYandEXPONENTIAL_BACKOFFenvironment variables.