feat: Add PAC github test#707
Open
srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
Open
feat: Add PAC github test#707srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
Conversation
manthinasai
reviewed
Feb 18, 2026
| This scenario tests configuring PAC with push and pull_request events in GitHub. | ||
|
|
||
| Steps: | ||
| // * Validate PAC Info Install |
Collaborator
There was a problem hiding this comment.
Can you remove the comment for this step
manthinasai
requested changes
Feb 25, 2026
| ctx := context.Background() | ||
| org := os.Getenv("GITHUB_ORG") | ||
| smeeURL := store.GetScenarioData("SMEE_URL") | ||
| token := os.Getenv("GITHUB_TOKEN") |
Collaborator
There was a problem hiding this comment.
The current GITHUB_TOKEN has the creds of openshift-pipelines.
If we use the same, repos might get created under openshift-pipelines .
So it would be better if we can use a new org token as disccussed.
Also need to rename the token GITHUB_TOKEN which you are using to some other name as the current one is used for configuration of few tests.
Also need to include the new env variable in CI secrets .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.