fix go.mod for release test#730
fix go.mod for release test#730srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
Conversation
Signed-off-by: Sri Vignesh <sselvan@redhat.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's Go module dependencies to ensure compatibility, stability, and access to the latest features and bug fixes, particularly for release testing. It includes an upgrade of the Go language version and a broad refresh of both direct and indirect module dependencies, reflecting a comprehensive effort to modernize the project's underlying libraries. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Go version and a large number of dependencies in go.mod and go.sum. While dependency updates are good for security and getting new features, I've found a couple of potential issues. The Go version is set to a future, unreleased version, which might cause tooling issues. More importantly, there are several replace directives that downgrade Kubernetes and Knative dependencies from the versions specified in the require block. This can lead to build failures and should be addressed.
| module github.com/openshift-pipelines/release-tests | ||
|
|
||
| go 1.25 | ||
| go 1.25.6 |
There was a problem hiding this comment.
The go directive is set to 1.25.6. As of now, Go 1.25 has not been released. Using a future version might cause compatibility issues with standard Go tooling and CI environments. It is recommended to use a stable, released version of Go (e.g., 1.22). If this is intentional, for example, to use features from a development branch of Go, it would be helpful to add a comment to the go.mod file explaining this.
No description provided.