Skip to content

fix go.mod for release test#730

Open
srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
srivickynesh:fix-gomod
Open

fix go.mod for release test#730
srivickynesh wants to merge 1 commit intoopenshift-pipelines:masterfrom
srivickynesh:fix-gomod

Conversation

@srivickynesh
Copy link
Collaborator

No description provided.

Signed-off-by: Sri Vignesh <sselvan@redhat.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project's Go module dependencies to ensure compatibility, stability, and access to the latest features and bug fixes, particularly for release testing. It includes an upgrade of the Go language version and a broad refresh of both direct and indirect module dependencies, reflecting a comprehensive effort to modernize the project's underlying libraries.

Highlights

  • Go Version Update: The Go language version was upgraded from 1.25 to 1.25.6.
  • Core Dependency Updates: Key direct dependencies such as manual-approval-gate, pipelines-as-code, tektoncd/cli, tektoncd/pipeline, tektoncd/triggers, and k8s.io modules were updated to their latest versions.
  • Extensive Indirect Dependency Refresh: Numerous indirect dependencies across various categories (e.g., cel.dev/expr, go-openapi components, prometheus components, opentelemetry libraries, golang.org/x modules, google.golang.org APIs, knative.dev/pkg) were updated, ensuring a comprehensive refresh of the module graph.
  • Dependency Graph Adjustments: New indirect dependencies were introduced, and some outdated ones were removed, streamlining the project's dependency tree.
Changelog
  • go.mod
    • Updated Go language version from 1.25 to 1.25.6.
    • Upgraded github.com/openshift-pipelines/manual-approval-gate from v0.7.0 to v0.8.0.
    • Upgraded github.com/openshift-pipelines/pipelines-as-code from v0.39.3 to v0.41.1.
    • Upgraded github.com/prometheus/common from v0.66.1 to v0.67.5.
    • Upgraded github.com/tektoncd/cli from v0.42.0 to v0.44.0.
    • Upgraded github.com/tektoncd/pipeline from v1.6.0 to v1.9.1.
    • Upgraded github.com/tektoncd/triggers from v0.34.0 to v0.35.0.
    • Upgraded k8s.io/api from v0.34.2 to v0.35.0.
    • Upgraded k8s.io/apimachinery from v0.34.2 to v0.35.0.
    • Upgraded knative.dev/pkg to a newer commit (20250915135827-db4c336acdbe to 20260114161248-8c840449eed2).
    • Updated indirect dependency cel.dev/expr from v0.24.0 to v0.25.1.
    • Added indirect dependencies github.com/clipperhouse/stringish and github.com/clipperhouse/uax29/v2.
    • Updated indirect dependency github.com/gdamore/tcell/v2 from v2.8.1 to v2.9.0.
    • Updated indirect github.com/go-openapi modules (e.g., jsonpointer, jsonreference, swag) to newer versions.
    • Updated indirect dependency github.com/google/cel-go from v0.26.1 to v0.27.0.
    • Updated indirect dependency github.com/google/gnostic-models from v0.7.0 to v0.7.1.
    • Updated indirect dependency github.com/google/go-querystring from v1.1.0 to v1.2.0.
    • Updated indirect dependency github.com/grpc-ecosystem/grpc-gateway/v2 from v2.27.2 to v2.27.4.
    • Removed indirect dependency github.com/josharian/intern.
    • Updated indirect dependency github.com/lucasb-eyer/go-colorful from v1.2.0 to v1.3.0.
    • Removed indirect dependency github.com/mailru/easyjson.
    • Updated indirect dependency github.com/mattn/go-runewidth from v0.0.16 to v0.0.19.
    • Updated indirect dependency github.com/prometheus/procfs from v0.17.0 to v0.19.2.
    • Removed indirect dependency github.com/rivo/uniseg.
    • Updated indirect dependency github.com/sirupsen/logrus from v1.9.3 to v1.9.4.
    • Updated indirect dependency github.com/spf13/cobra from v1.10.1 to v1.10.2.
    • Removed indirect dependency github.com/stoewer/go-strcase.
    • Removed indirect dependency github.com/titanous/rocacheck.
    • Updated indirect go.opentelemetry.io modules (auto/sdk, otel, otel/metric, otel/trace) to newer versions.
    • Updated indirect golang.org/x modules (exp, net, oauth2, sync, sys, term, text, time) to newer versions.
    • Updated indirect google.golang.org modules (api, genproto/googleapis/api, genproto/googleapis/rpc, grpc) to newer versions.
    • Updated indirect k8s.io modules (apiextensions-apiserver, kube-openapi, utils) to newer versions.
    • Updated indirect dependency knative.dev/eventing from v0.46.5 to v0.47.0.
  • go.sum
    • Updated checksums for all modified dependencies listed in go.mod.
    • Added new checksum entries for github.com/clipperhouse/stringish, github.com/clipperhouse/uax29/v2, and github.com/golang-jwt/jwt/v5.
    • Removed checksum entries for github.com/go-jose/go-jose/v4, github.com/letsencrypt/boulder, github.com/josharian/intern, github.com/mailru/easyjson, github.com/rivo/uniseg, github.com/stoewer/go-strcase, and github.com/titanous/rocacheck.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version and a large number of dependencies in go.mod and go.sum. While dependency updates are good for security and getting new features, I've found a couple of potential issues. The Go version is set to a future, unreleased version, which might cause tooling issues. More importantly, there are several replace directives that downgrade Kubernetes and Knative dependencies from the versions specified in the require block. This can lead to build failures and should be addressed.

module github.com/openshift-pipelines/release-tests

go 1.25
go 1.25.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The go directive is set to 1.25.6. As of now, Go 1.25 has not been released. Using a future version might cause compatibility issues with standard Go tooling and CI environments. It is recommended to use a stable, released version of Go (e.g., 1.22). If this is intentional, for example, to use features from a development branch of Go, it would be helpful to add a comment to the go.mod file explaining this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant