Skip to content

Conversation

@liouk
Copy link
Member

@liouk liouk commented Oct 2, 2025

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

Hello @liouk! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 2, 2025
@liouk liouk changed the title WIP: [release-4.20] Promote BYO OIDC features [release-4.20] Promote BYO OIDC features Oct 2, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@everettraven
Copy link
Contributor

This should not merge until the 4.20 branch is open for z-stream backports.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025
@everettraven
Copy link
Contributor

/assign

@liouk
Copy link
Member Author

liouk commented Oct 13, 2025

/test verify-feature-promotion

2 similar comments
@liouk
Copy link
Member Author

liouk commented Oct 15, 2025

/test verify-feature-promotion

@liouk
Copy link
Member Author

liouk commented Oct 21, 2025

/test verify-feature-promotion

@xingxingxia
Copy link

/retest-required

@xingxingxia
Copy link

Though there were still some Required jobs failing, I anyway pre-merge tested this PR + openshift/cluster-authentication-operator#802 together with

# Payload 1
build 4.20.0-0.nightly-2025-10-21-003434,openshift/api#2515,openshift/cluster-authentication-operator#802

# Payload 2
build 4.20.0-0.nightly-2025-10-21-173356,openshift/api#2515,openshift/cluster-authentication-operator#802

In a fresh env of cluster-bot payload 1, configured external oidc with Entra ID, pre-upgrade related tests passed including oc / console interactive logins, extra / uid checks, clusterversion/version and authentication.config/cluster and co/authentication's .status against their respecitve Jira bugs et al.
Upgrading of the env to cluster-bot payload 2 succeeded without the filed upgrade bug any more. Post-upgrade tests passed.
Regression tests of rollback to IDP and post-rollback interactive logins also passed.

So adding /verified label:
/verified by @xingxingxia

I didn't yet have chance to cover testing 4.19 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc, also didn't test 4.20.0 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc. Because I had tested "4.21-nightly-payload -> upgrade to 4.21-external-oidc-GA-clusterbot-payload -> configure external oidc" without issue, I believe same confidence.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 23, 2025
@openshift-ci-robot
Copy link

@xingxingxia: This PR has been marked as verified by @xingxingxia.

In response to this:

Though there were still some Required jobs failing, I anyway pre-merge tested this PR + openshift/cluster-authentication-operator#802 together with

# Payload 1
build 4.20.0-0.nightly-2025-10-21-003434,openshift/api#2515,openshift/cluster-authentication-operator#802

# Payload 2
build 4.20.0-0.nightly-2025-10-21-173356,openshift/api#2515,openshift/cluster-authentication-operator#802

In a fresh env of cluster-bot payload 1, configured external oidc with Entra ID, pre-upgrade related tests passed including oc / console interactive logins, extra / uid checks, clusterversion/version and authentication.config/cluster and co/authentication's .status against their respecitve Jira bugs et al.
Upgrading of the env to cluster-bot payload 2 succeeded without the filed upgrade bug any more. Post-upgrade tests passed.
Regression tests of rollback to IDP and post-rollback interactive logins also passed.

So adding /verified label:
/verified by @xingxingxia

I didn't yet have chance to cover testing 4.19 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc, also didn't test 4.20.0 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc. Because I had tested "4.21-nightly-payload -> upgrade to 4.21-external-oidc-GA-clusterbot-payload -> configure external oidc" without issue, I believe same confidence.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Oct 24, 2025

/test verify-feature-promotion

1 similar comment
@everettraven
Copy link
Contributor

/test verify-feature-promotion

@xingxingxia
Copy link

/retest-required

@liouk
Copy link
Member Author

liouk commented Nov 10, 2025

/test verify-feature-promotion

@liouk
Copy link
Member Author

liouk commented Nov 11, 2025

Holding until we're ready to merge openshift/hypershift#7204 as well.

/hold

@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 11, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@liouk
Copy link
Member Author

liouk commented Nov 11, 2025

/test verify-feature-promotion

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liouk liouk changed the title [release-4.20] Promote BYO OIDC features [release-4.20] OCPBUGS-1907: Promote BYO OIDC features Nov 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 11, 2025
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-1907, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to target the "4.20.z" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-1907 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual regeneration and backport of #2454.

Respective approved SBAR: https://docs.google.com/presentation/d/1MrqVU10UYBHNvCu5XrybHejHcqLRf1zsedCYv1hlZVQ/edit?slide=id.g37f5a0492ea_0_0#slide=id.g37f5a0492ea_0_0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk liouk changed the title [release-4.20] OCPBUGS-1907: Promote BYO OIDC features [release-4.20] OCPBUGS-64940: Promote BYO OIDC features Nov 11, 2025
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-64940, which is invalid:

  • expected the bug to target the "4.20.z" version, but no target version was set
  • expected Jira Issue OCPBUGS-64940 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual regeneration and backport of #2454.

Respective approved SBAR: https://docs.google.com/presentation/d/1MrqVU10UYBHNvCu5XrybHejHcqLRf1zsedCYv1hlZVQ/edit?slide=id.g37f5a0492ea_0_0#slide=id.g37f5a0492ea_0_0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Nov 11, 2025

/jira refresh

@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-64940, which is invalid:

  • expected Jira Issue OCPBUGS-64940 to depend on a bug targeting a version in 4.21.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Nov 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 11, 2025
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-64940, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-64941 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-64941 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants