-
Notifications
You must be signed in to change notification settings - Fork 79
chore: bump Go version to 1.25.3 #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Need to update the CI image openshift/release#72756 |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
==========================================
+ Coverage 52.91% 52.95% +0.03%
==========================================
Files 86 86
Lines 6525 6525
==========================================
+ Hits 3453 3455 +2
+ Misses 2610 2609 -1
+ Partials 462 461 -1 🚀 New features to boost your workflow:
|
|
@feichashao: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this looks good to me. No major changes except a Go version bump. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7vicky, feichashao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| module github.com/openshift/backplane-cli | ||
|
|
||
| go 1.24.4 | ||
| go 1.25.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should ideally be the minimum version of Go that is supported. By bumping this to 1.25.3, you are saying all consumers have to be on at least 1.25.3 to use this module.
Now, since this is a CLI, ideally that is nobody, but for some reason we are using the CLI as business logic in a lot of repos :/
What type of PR is this?
What this PR does / Why we need it?
Update the Go version to 1.25.3 . This is the latest version in go-toolset at the time of checking.
Other dependency updates requires a high Go version so raising this PR to bump.
Which Jira/Github issue(s) does this PR fix?
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash