OCPBUGS-70212: testGatewayAPIDNS: Fix nil gateway in cleanup #1330
Conversation
Don't overwrite the gateway variable's value from createGatewayWithListeners with a possibly nil value from assertGatewaySuccessful. The gateway variable is used in a cleanup handler, which would panic if the variable had a nil value. The gateway value from assertGatewaySuccessful isn't really needed, so it can be safely ignored. Follow-up to commit d2b8c89. Follow-up to commit 2b3eb70. This commit fixes OCPBUGS-70212. https://issues.redhat.com/browse/OCPBUGS-70212 * test/e2e/gateway_api_test.go (testGatewayAPIDNSListenerWithNoHostname) (testGatewayAPIDNSListenerUpdate): Ignore the return value from assertGatewaySuccessful.
openshift-ci-robot
added
jira/severity-low
|
@Miciah: This pull request references Jira Issue OCPBUGS-70212, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Don't overwrite the gateway variable's value from
createGatewayWithListenerswith a possibly nil value fromassertGatewaySuccessful.The gateway variable is used in a cleanup handler, which would panic if the variable had a nil value. The gateway value from
assertGatewaySuccessfulisn't really needed, so it can be safely ignored.Follow-up to #1213 and #1304.