[release-4.20] OCPBUGS-66412: Fix whereabouts-token-watcher DaemonSet improvements #2850

openshift-cherrypick-robot · 2025-12-04T15:31:04Z

This is an automated cherry-pick of #2841

/assign pliurh

This commit introduces several improvements to the whereabouts-token-watcher DaemonSet: - Corrects a typo in the description. - Adds logging helper functions for better script output. - Ensures the service account token is read dynamically during kubeconfig generation. - Fixes the logical grouping in the CA file change detection condition. - Increases the kubeconfig regeneration check interval to 60 seconds. - Mounts the host's CNI network directory for proper CNI configuration management. Signed-off-by: Peng Liu <pliu@redhat.com>

openshift-ci-robot · 2025-12-04T15:31:18Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-63443 has been cloned as Jira Issue OCPBUGS-66412. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-66412: Fix whereabouts-token-watcher DaemonSet improvements

Details

In response to this:

This is an automated cherry-pick of #2841

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-12-04T15:31:24Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-12-04T15:31:49Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-66412, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-63443 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2841

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-12-05T08:50:33Z

/retest-required

openshift-ci · 2025-12-05T12:56:16Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`7ad5624`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pliurh · 2025-12-08T02:58:45Z

/cherrypick release-4.19

openshift-cherrypick-robot · 2025-12-08T02:58:47Z

@pliurh: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pliurh · 2025-12-09T07:27:53Z

/jira refresh

openshift-ci-robot · 2025-12-09T07:27:58Z

@pliurh: This pull request references Jira Issue OCPBUGS-66412, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-12-09T07:29:47Z

/jira refresh

openshift-ci-robot · 2025-12-09T07:29:52Z

@pliurh: This pull request references Jira Issue OCPBUGS-66412, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-12-09T07:30:24Z

/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

openshift-ci · 2025-12-09T07:30:43Z

@pliurh: Overrode contexts on behalf of pliurh: ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Details

In response to this:

/override ci/prow/e2e-aws-ovn-windows
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pliurh · 2025-12-09T07:32:27Z

/jira refresh

openshift-ci-robot · 2025-12-09T07:32:37Z

@pliurh: This pull request references Jira Issue OCPBUGS-66412, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-63443 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-63443 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-12-09T07:33:01Z

/label backport-risk-assessed

pliurh · 2025-12-09T07:33:29Z

@yingwang-0320 can you help with the pre-merge test?

yingwang-0320 · 2025-12-10T05:31:11Z

/verified by pre-merge testing

openshift-ci-robot · 2025-12-10T05:31:21Z

@yingwang-0320: This PR has been marked as verified by pre-merge testing.

Details

In response to this:

/verified by pre-merge testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-12-11T03:06:15Z

/approve
/lgtm

openshift-ci · 2025-12-11T03:06:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pliurh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-12-11T06:57:49Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-66412
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66412 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #2841

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-12-11T06:58:44Z

@pliurh: new pull request created: #2857

Details

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot · 2025-12-12T06:33:20Z

Fix included in accepted release 4.20.0-0.nightly-2025-12-11-233406

openshift-cherrypick-robot assigned pliurh Dec 4, 2025

openshift-cherrypick-robot mentioned this pull request Dec 4, 2025

OCPBUGS-63443: Fix whereabouts-token-watcher DaemonSet improvements #2841

Merged

openshift-ci bot changed the title ~~[release-4.20] OCPBUGS-63443: Fix whereabouts-token-watcher DaemonSet improvements~~ [release-4.20] OCPBUGS-66412: Fix whereabouts-token-watcher DaemonSet improvements Dec 4, 2025

openshift-ci bot requested review from kyrtapz and pperiyasamy December 4, 2025 15:31

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 9, 2025

openshift-ci bot assigned anuragthehatter and asood-rh Dec 9, 2025

openshift-ci bot assigned barbora137, eurijon, huiran0826, imatza-rh, jechen0648, Meina-rh and mffiedler Dec 9, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2025

openshift-merge-bot bot merged commit 698e349 into openshift:release-4.20 Dec 11, 2025
27 of 28 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 11, 2025

[release-4.19] OCPBUGS-67208: Fix whereabouts-token-watcher DaemonSet improvements #2857

Open

[release-4.20] OCPBUGS-66412: Fix whereabouts-token-watcher DaemonSet improvements #2850

[release-4.20] OCPBUGS-66412: Fix whereabouts-token-watcher DaemonSet improvements #2850

Uh oh!

Conversation

openshift-cherrypick-robot commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

coderabbitai bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

pliurh commented Dec 5, 2025

Uh oh!

openshift-ci bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pliurh commented Dec 8, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 8, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

openshift-ci-robot commented Dec 9, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

openshift-ci-robot commented Dec 9, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

openshift-ci bot commented Dec 9, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

openshift-ci-robot commented Dec 9, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

pliurh commented Dec 9, 2025

Uh oh!

yingwang-0320 commented Dec 10, 2025

Uh oh!

openshift-ci-robot commented Dec 10, 2025

Uh oh!

pliurh commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 11, 2025

Uh oh!

openshift-cherrypick-robot commented Dec 11, 2025

Uh oh!

openshift-merge-robot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

coderabbitai bot commented Dec 4, 2025 •

edited

Loading

openshift-ci bot commented Dec 5, 2025 •

edited

Loading