Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #2579

/assign openshift-cherrypick-robot

The metrics server was incorectly enabled in acd67b4
Revert this behavior by specifying the metrics port in the options.

Signed-off-by: Patryk Diak <pdiak@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-45086 has been cloned as Jira Issue OCPBUGS-67000. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-67000: Re-disable metrics server

Details

In response to this:

This is an automated cherry-pick of #2579

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-45086: Re-disable metrics server [release-4.16] OCPBUGS-67000: Re-disable metrics server Dec 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-67000, which is invalid:

  • expected dependent Jira Issue OCPBUGS-45086 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2579

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from arkadeepsen and tssurya December 9, 2025 08:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade-ipsec 80685e5 link false /test 4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade-ipsec
ci/prow/security 80685e5 link false /test security
ci/prow/4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade 80685e5 link false /test 4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qiowang721
Copy link

/verified by @qiowang721
pre-merge testing passed.
Steps:

1. build image with pr and setup compact OCP cluster
build 4.16,openshift/cluster-network-operator#2855

2. create a hostnetwork pod, listening on port 8080
% oc get pod -owide -n test
NAME        READY   STATUS    RESTARTS   AGE   IP           NODE                                       NOMINATED NODE   READINESS GATES
hello-pod   1/1     Running   0          5s    10.0.57.95   ip-10-0-57-95.us-east-2.compute.internal              

3. check on the node which hostnetowrk pod lands on, the pod is listening on port 8080
% oc debug node/ip-10-0-57-95.us-east-2.compute.internal
Temporary namespace openshift-debug-79trc is created for debugging node...
Starting pod/ip-10-0-57-95us-east-2computeinternal-debug-2zvp7 ...
To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
Pod IP: 10.0.57.95
If you don't see a command prompt, try pressing enter.
sh-5.1# netstat -tulpen | grep 8080
tcp6       0      0 :::8080                 :::*                    LISTEN      1000740000 1845726    184049/hello_opensh

4. check the network-operator pod is not in CrashLoopBackOff state, and there is no error message about metrics server
% oc get pod -n openshift-network-operator -l name=network-operator
NAME                                READY   STATUS    RESTARTS       AGE
network-operator-559646d665-6splz   1/1     Running   2 (103m ago)   117m
% oc describe pod/network-operator-559646d665-6splz -n openshift-network-operator | grep "metrics server"
% oc describe pod/network-operator-559646d665-6splz -n openshift-network-operator | grep "address already in use"
%

5. check cluster-network-operator is not DEGRADED
% oc get co | grep network
network                                    4.16.0-0-2025-12-10-015830-test-ci-ln-lky89fb-latest   True        False         False      117m

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 10, 2025
@openshift-ci-robot
Copy link
Contributor

@qiowang721: This PR has been marked as verified by @qiowang721.

Details

In response to this:

/verified by @qiowang721
pre-merge testing passed.
Steps:

1. build image with pr and setup compact OCP cluster
build 4.16,openshift/cluster-network-operator#2855

2. create a hostnetwork pod, listening on port 8080
% oc get pod -owide -n test
NAME        READY   STATUS    RESTARTS   AGE   IP           NODE                                       NOMINATED NODE   READINESS GATES
hello-pod   1/1     Running   0          5s    10.0.57.95   ip-10-0-57-95.us-east-2.compute.internal              

3. check on the node which hostnetowrk pod lands on, the pod is listening on port 8080
% oc debug node/ip-10-0-57-95.us-east-2.compute.internal
Temporary namespace openshift-debug-79trc is created for debugging node...
Starting pod/ip-10-0-57-95us-east-2computeinternal-debug-2zvp7 ...
To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
Pod IP: 10.0.57.95
If you don't see a command prompt, try pressing enter.
sh-5.1# netstat -tulpen | grep 8080
tcp6       0      0 :::8080                 :::*                    LISTEN      1000740000 1845726    184049/hello_opensh

4. check the network-operator pod is not in CrashLoopBackOff state, and there is no error message about metrics server
% oc get pod -n openshift-network-operator -l name=network-operator
NAME                                READY   STATUS    RESTARTS       AGE
network-operator-559646d665-6splz   1/1     Running   2 (103m ago)   117m
% oc describe pod/network-operator-559646d665-6splz -n openshift-network-operator | grep "metrics server"
% oc describe pod/network-operator-559646d665-6splz -n openshift-network-operator | grep "address already in use"
%

5. check cluster-network-operator is not DEGRADED
% oc get co | grep network
network                                    4.16.0-0-2025-12-10-015830-test-ci-ln-lky89fb-latest   True        False         False      117m

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants