OCPBUGS-70324: Revert the console-shared.json to console-shared directory #15885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
jira/valid-reference
Contributor
|
@cajieh: This pull request references Jira Issue OCPBUGS-70324, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe "View all events" translation key is being relocated from the console-shared locale package to the public locale package across all supported languages (English, Spanish, French, Japanese, Korean, Chinese). Two component files are updated to reference the new translation key location. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🧬 Code graph analysis (2)frontend/public/components/dashboard/project-dashboard/activity-card.tsx (1)
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/activity-card.tsx (1)
🔇 Additional comments (13)
Comment |
openshift-ci
bot
added
component/core
Contributor
Author
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
Contributor
|
@cajieh: This pull request references Jira Issue OCPBUGS-70324, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Fix all issues with AI Agents 🤖
In @frontend/packages/console-shared/locales/en/console-shared.json:
- Line 312: The JSON entry "Set maxUnavaliable to 0" contains a typo; update the
key and its value to use the correct spelling "maxUnavailable" (i.e., change
"Set maxUnavaliable to 0" to "Set maxUnavailable to 0") so the user-facing
string and lookup key both reflect the correct term.
- Around line 1-320: Typo in the locale key "maxUnavaliable" (should be
"maxUnavailable") — update the JSON key/value to correct spelling. Locate the
entry with the text "Set maxUnavaliable to 0" (appearing in the
PodDisruptionBudget description block) and rename the key/value to "Set
maxUnavailable to 0" and adjust any related sentence occurrences
("maxUnavaliable" → "maxUnavailable") so i18n lookups use the correct term.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (2)
frontend/packages/console-shared/locales/en/console-shared.jsonfrontend/public/locales/en/console-shared.json
💤 Files with no reviewable changes (1)
- frontend/public/locales/en/console-shared.json
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
frontend/packages/console-shared/locales/en/console-shared.json
Comment on lines
1
to
320
| { | ||
| "View all events": "View all events", | ||
| "Actions": "Actions", | ||
| "An error occurred": "An error occurred", | ||
| "Note: Some fields may not be represented in this form view. Please select \"YAML view\" for full control.": "Note: Some fields may not be represented in this form view. Please select \"YAML view\" for full control.", | ||
| "Dev preview": "Dev preview", | ||
| "Tech preview": "Tech preview", | ||
| "No results found": "No results found", | ||
| "No results match the filter criteria. Remove filters or clear all filters to show results.": "No results match the filter criteria. Remove filters or clear all filters to show results.", | ||
| "Clear all filters": "Clear all filters", | ||
| "Relevance": "Relevance", | ||
| "A-Z": "A-Z", | ||
| "Z-A": "Z-A", | ||
| "None": "None", | ||
| "Filter by keyword...": "Filter by keyword...", | ||
| "Group by": "Group by", | ||
| "{{totalItems}} items": "{{totalItems}} items", | ||
| "Type": "Type", | ||
| "All items": "All items", | ||
| "Other": "Other", | ||
| "Software Catalog": "Software Catalog", | ||
| "Catalog items": "Catalog items", | ||
| "Provided by {{provider}}": "Provided by {{provider}}", | ||
| "N/A": "N/A", | ||
| "Provider": "Provider", | ||
| "Created at": "Created at", | ||
| "Support": "Support", | ||
| "Documentation": "Documentation", | ||
| "Get support": "Get support", | ||
| "Refer documentation": "Refer documentation", | ||
| "Could not load configuration.": "Could not load configuration.", | ||
| "Saved.": "Saved.", | ||
| "This config update requires a console rollout, this can take up to a minute and require a browser refresh.": "This config update requires a console rollout, this can take up to a minute and require a browser refresh.", | ||
| "Could not save configuration.": "Could not save configuration.", | ||
| "Started": "Started", | ||
| "There are no recent events.": "There are no recent events.", | ||
| "Resume": "Resume", | ||
| "Pause": "Pause", | ||
| "Recent events": "Recent events", | ||
| "There are no ongoing activities.": "There are no ongoing activities.", | ||
| "Ongoing": "Ongoing", | ||
| "Not available": "Not available", | ||
| "{{count}} resource_one": "{{count}} resource", | ||
| "{{count}} resource_other": "{{count}} resources", | ||
| "{{count}} resource reached quota_one": "{{count}} resource reached quota", | ||
| "{{count}} resource reached quota_other": "{{count}} resource reached quotas", | ||
| "none are at quota": "none are at quota", | ||
| "No ResourceQuotas": "No ResourceQuotas", | ||
| "Go to documentation": "Go to documentation", | ||
| "View details": "View details", | ||
| "Alerts could not be loaded.": "Alerts could not be loaded.", | ||
| "({{operatorStatusLength}} installed)": "({{operatorStatusLength}} installed)", | ||
| "Status": "Status", | ||
| "All {{status}}": "All {{status}}", | ||
| "View all": "View all", | ||
| "Unknown": "Unknown", | ||
| "Pending": "Pending", | ||
| "Updating": "Updating", | ||
| "Degraded": "Degraded", | ||
| "Loading": "Loading", | ||
| "Upgrade available": "Upgrade available", | ||
| "{{title}} breakdown": "{{title}} breakdown", | ||
| "Total capacity": "Total capacity", | ||
| "Total limit": "Total limit", | ||
| "Current utilization": "Current utilization", | ||
| "Current available capacity": "Current available capacity", | ||
| "Total requested": "Total requested", | ||
| "By {{label}}": "By {{label}}", | ||
| "Top consumer by {{label}}": "Top consumer by {{label}}", | ||
| "View more": "View more", | ||
| "Top {{label}} consumers": "Top {{label}} consumers", | ||
| "Top consumers": "Top consumers", | ||
| "Select consumer type": "Select consumer type", | ||
| "time axis": "time axis", | ||
| "Resource": "Resource", | ||
| "Usage": "Usage", | ||
| "1 hour": "1 hour", | ||
| "6 hours": "6 hours", | ||
| "24 hours": "24 hours", | ||
| "{{amount}} in": "{{amount}} in", | ||
| "{{amount}} out": "{{amount}} out", | ||
| "in": "in", | ||
| "out": "out", | ||
| "View {{title}} metrics in query browser": "View {{title}} metrics in query browser", | ||
| "{{humanAvailable}} available of {{humanMax}}": "{{humanAvailable}} available of {{humanMax}}", | ||
| "{{humanAvailable}} available": "{{humanAvailable}} available", | ||
| "{{humanLimit}} total limit": "{{humanLimit}} total limit", | ||
| "Error loading - {{placeholder}}": "Error loading - {{placeholder}}", | ||
| "Value": "Value", | ||
| "Resource requirements": "Resource requirements", | ||
| "Limits": "Limits", | ||
| "Requests": "Requests", | ||
| "Update strategy": "Update strategy", | ||
| "Node affinity": "Node affinity", | ||
| "Pod affinity": "Pod affinity", | ||
| "Expressions": "Expressions", | ||
| "Select {{title}}": "Select {{title}}", | ||
| "A form is not available for this resource. Please use the YAML view.": "A form is not available for this resource. Please use the YAML view.", | ||
| "There is some issue in this form view. Please select \"YAML view\" for full control.": "There is some issue in this form view. Please select \"YAML view\" for full control.", | ||
| "Create": "Create", | ||
| "Cancel": "Cancel", | ||
| "Advanced configuration": "Advanced configuration", | ||
| "Remove {{singularLabel}}": "Remove {{singularLabel}}", | ||
| "Add {{singularLabel}}": "Add {{singularLabel}}", | ||
| "Error": "Error", | ||
| "Fix the following errors:": "Fix the following errors:", | ||
| "true": "true", | ||
| "Select {{label}}": "Select {{label}}", | ||
| "Cluster does not have resource {{groupVersionKind}}": "Cluster does not have resource {{groupVersionKind}}", | ||
| "Copy code to clipboard": "Copy code to clipboard", | ||
| "Content copied to clipboard": "Content copied to clipboard", | ||
| "Download code": "Download code", | ||
| "Shortcuts": "Shortcuts", | ||
| "Upload code": "Upload code", | ||
| "Drag and drop a file or upload one.": "Drag and drop a file or upload one.", | ||
| "Browse": "Browse", | ||
| "Start from scratch": "Start from scratch", | ||
| "Start editing": "Start editing", | ||
| "Ask OpenShift Lightspeed": "Ask OpenShift Lightspeed", | ||
| "View all editor shortcuts": "View all editor shortcuts", | ||
| "Activate auto complete": "Activate auto complete", | ||
| "Toggle Tab action between insert Tab character and move focus out of editor": "Toggle Tab action between insert Tab character and move focus out of editor", | ||
| "View document outline": "View document outline", | ||
| "View property descriptions": "View property descriptions", | ||
| "Save": "Save", | ||
| "Hide sidebar": "Hide sidebar", | ||
| "Show sidebar": "Show sidebar", | ||
| "Restricted access": "Restricted access", | ||
| "You don't have access to this section due to cluster policy": "You don't have access to this section due to cluster policy", | ||
| "Error details": "Error details", | ||
| "No {{label}} found": "No {{label}} found", | ||
| "Not found": "Not found", | ||
| "Extension error": "Extension error", | ||
| "Something wrong happened": "Something wrong happened", | ||
| "An error occurred. Please try again.": "An error occurred. Please try again.", | ||
| "Reload page": "Reload page", | ||
| "You made changes to this page.": "You made changes to this page.", | ||
| "Click {{submit}} to save changes or {{reset}} to cancel changes.": "Click {{submit}} to save changes or {{reset}} to cancel changes.", | ||
| "Reload": "Reload", | ||
| "Download": "Download", | ||
| "Name": "Name", | ||
| "Add value": "Add value", | ||
| "Filter by type...": "Filter by type...", | ||
| "Filter by type": "Filter by type", | ||
| "{{count}} item_one": "{{count}} item", | ||
| "{{count}} item_other": "{{count}} items", | ||
| "No results match the filter criteria": "No results match the filter criteria", | ||
| "Clear filter": "Clear filter", | ||
| "Remove key/value": "Remove key/value", | ||
| "Key": "Key", | ||
| "Drag and drop file with your value here or browse to upload it.": "Drag and drop file with your value here or browse to upload it.", | ||
| "Add key/value": "Add key/value", | ||
| "Add values": "Add values", | ||
| "Remove": "Remove", | ||
| "Create new option \"{{option}}\"": "Create new option \"{{option}}\"", | ||
| "Current selections": "Current selections", | ||
| "Configure via:": "Configure via:", | ||
| "Form view": "Form view", | ||
| "YAML view": "YAML view", | ||
| "Invalid YAML cannot be persisted": "Invalid YAML cannot be persisted", | ||
| "Switching to form view will delete any invalid YAML.": "Switching to form view will delete any invalid YAML.", | ||
| "Switch and delete": "Switch and delete", | ||
| "Form view is disabled for this chart because the schema is not available": "Form view is disabled for this chart because the schema is not available", | ||
| "Getting started resources": "Getting started resources", | ||
| "Use our collection of resources to help you get started with the Console.": "Use our collection of resources to help you get started with the Console.", | ||
| "Close": "Close", | ||
| "Expandable details": "Expandable details", | ||
| "More info": "More info", | ||
| "View all quick starts": "View all quick starts", | ||
| "Build with guided documentation": "Build with guided documentation", | ||
| "Follow guided documentation to build applications and familiarize yourself with key features.": "Follow guided documentation to build applications and familiarize yourself with key features.", | ||
| "Show getting started resources": "Show getting started resources", | ||
| "Not all Containers have health checks to ensure your Application is running correctly.": "Not all Containers have health checks to ensure your Application is running correctly.", | ||
| "Container {{containersName}} does not have health checks to ensure your Application is running correctly.": "Container {{containersName}} does not have health checks to ensure your Application is running correctly.", | ||
| "Health checks": "Health checks", | ||
| "Add health checks": "Add health checks", | ||
| "Unknown error removing {{hpaLabel}} {{hpaName}}.": "Unknown error removing {{hpaLabel}} {{hpaName}}.", | ||
| "Remove {{label}}?": "Remove {{label}}?", | ||
| "Are you sure you want to remove the {{hpaLabel}}": "Are you sure you want to remove the {{hpaLabel}}", | ||
| "from": "from", | ||
| "The resources that are attached to the {{hpaLabel}} will be deleted.": "The resources that are attached to the {{hpaLabel}} will be deleted.", | ||
| "(Opens in new tab)": "(Opens in new tab)", | ||
| "Try again": "Try again", | ||
| "Error loading {{label}}": "Error loading {{label}}", | ||
| "Copy to clipboard": "Copy to clipboard", | ||
| "Run in Web Terminal": "Run in Web Terminal", | ||
| "Successfully copied to clipboard!": "Successfully copied to clipboard!", | ||
| "Running in Web Terminal": "Running in Web Terminal", | ||
| "Console plugin enablement - {{plugin}}": "Console plugin enablement - {{plugin}}", | ||
| "Console plugin enablement": "Console plugin enablement", | ||
| "This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "This operator includes a console plugin which provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.", | ||
| "This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.": "This console plugin provides a custom interface that can be included in the console. Updating the enablement of this console plugin will prompt for the console to be refreshed once it has been updated. Make sure you trust this console plugin before enabling.", | ||
| "No restrictions": "No restrictions", | ||
| "Deny all inbound traffic": "Deny all inbound traffic", | ||
| "Create Namespace": "Create Namespace", | ||
| "A Namespace name must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name' or '123-abc').": "A Namespace name must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name' or '123-abc').", | ||
| "You must create a Namespace to be able to create projects that begin with 'openshift-', 'kubernetes-', or 'kube-'.": "You must create a Namespace to be able to create projects that begin with 'openshift-', 'kubernetes-', or 'kube-'.", | ||
| "Labels": "Labels", | ||
| "Default network policy": "Default network policy", | ||
| "Create Project": "Create Project", | ||
| "An OpenShift project is an alternative representation of a Kubernetes namespace.": "An OpenShift project is an alternative representation of a Kubernetes namespace.", | ||
| "Learn more about working with projects": "Learn more about working with projects", | ||
| "A Project name must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name' or '123-abc').": "A Project name must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name' or '123-abc').", | ||
| "Display name": "Display name", | ||
| "Description": "Description", | ||
| "Delete": "Delete", | ||
| "This action cannot be undone. All associated Deployments, Routes, Builds, Pipelines, Storage/PVCs, Secrets, and ConfigMaps will be deleted.": "This action cannot be undone. All associated Deployments, Routes, Builds, Pipelines, Storage/PVCs, Secrets, and ConfigMaps will be deleted.", | ||
| "Confirm deletion by typing <1>{{resourceName}}</1> below:": "Confirm deletion by typing <1>{{resourceName}}</1> below:", | ||
| "Description:": "Description:", | ||
| "Component trace:": "Component trace:", | ||
| "Stack trace:": "Stack trace:", | ||
| "Show details": "Show details", | ||
| "No projects found": "No projects found", | ||
| "No namespaces found": "No namespaces found", | ||
| "No results match the filter criteria.": "No results match the filter criteria.", | ||
| "Clear filters": "Clear filters", | ||
| "Select project...": "Select project...", | ||
| "Select namespace...": "Select namespace...", | ||
| "Show default projects": "Show default projects", | ||
| "Show default namespaces": "Show default namespaces", | ||
| "Projects": "Projects", | ||
| "Namespaces": "Namespaces", | ||
| "Favorites": "Favorites", | ||
| "All Projects": "All Projects", | ||
| "All Namespaces": "All Namespaces", | ||
| "Project": "Project", | ||
| "Namespace": "Namespace", | ||
| "Enable Autoscale": "Enable Autoscale", | ||
| "Increase the Pod count": "Increase the Pod count", | ||
| "Decrease the Pod count": "Decrease the Pod count", | ||
| "No Pods found for this resource.": "No Pods found for this resource.", | ||
| "Hide waiting pods with errors": "Hide waiting pods with errors", | ||
| "Show waiting pods with errors": "Show waiting pods with errors", | ||
| "Waiting for the first build to run successfully. You may temporarily see \"ImagePullBackOff\" and \"ErrImagePull\" errors while waiting.": "Waiting for the first build to run successfully. You may temporarily see \"ImagePullBackOff\" and \"ErrImagePull\" errors while waiting.", | ||
| "View all {{podSize}}": "View all {{podSize}}", | ||
| "Quick search bar": "Quick search bar", | ||
| "No results": "No results", | ||
| "Quick search list": "Quick search list", | ||
| "Quick search": "Quick search", | ||
| "Hover": "Hover", | ||
| "Drag": "Drag", | ||
| "Click": "Click", | ||
| "Right click": "Right click", | ||
| "Drag + Drop": "Drag + Drop", | ||
| "{{labels}} content is not available in the catalog at this time due to loading failures.": "{{labels}} content is not available in the catalog at this time due to loading failures.", | ||
| "Timed out fetching new data. The data below is stale.": "Timed out fetching new data. The data below is stale.", | ||
| "Information": "Information", | ||
| "In progress": "In progress", | ||
| "Healthy": "Healthy", | ||
| "Warning": "Warning", | ||
| "Enable": "Enable", | ||
| "Disable": "Disable", | ||
| "Enabling console plugin": "Enabling console plugin", | ||
| "This console plugin will be able to provide a custom interface and run any Kubernetes command as the logged in user. Make sure you trust it before enabling.": "This console plugin will be able to provide a custom interface and run any Kubernetes command as the logged in user. Make sure you trust it before enabling.", | ||
| "OLSConfig": "OLSConfig", | ||
| "OLSConfigs": "OLSConfigs", | ||
| "{{label}} details": "{{label}} details", | ||
| "Provisioned as node": "Provisioned as node", | ||
| "Select options": "Select options", | ||
| "Select input": "Select input", | ||
| "Pod": "Pod", | ||
| "Pods": "Pods", | ||
| "Scaled to 0": "Scaled to 0", | ||
| "Scaling to {{podSubTitle}}": "Scaling to {{podSubTitle}}", | ||
| "Autoscaled": "Autoscaled", | ||
| "to 0": "to 0", | ||
| "Autoscaling": "Autoscaling", | ||
| "to {{count}} Pod_one": "to {{count}} Pod", | ||
| "to {{count}} Pod_other": "to {{count}} Pods", | ||
| "Allow reading Nodes in the core API groups (for ClusterRoleBinding)": "Allow reading Nodes in the core API groups (for ClusterRoleBinding)", | ||
| "This \"ClusterRole\" is allowed to read the resource \"Nodes\" in the core group (because a Node is cluster-scoped, this must be bound with a \"ClusterRoleBinding\" to be effective).": "This \"ClusterRole\" is allowed to read the resource \"Nodes\" in the core group (because a Node is cluster-scoped, this must be bound with a \"ClusterRoleBinding\" to be effective).", | ||
| "\"GET/POST\" requests to non-resource endpoint and all subpaths (for ClusterRoleBinding)": "\"GET/POST\" requests to non-resource endpoint and all subpaths (for ClusterRoleBinding)", | ||
| "This \"ClusterRole\" is allowed to \"GET\" and \"POST\" requests to the non-resource endpoint \"/healthz\" and all subpaths (must be in the \"ClusterRole\" bound with a \"ClusterRoleBinding\" to be effective).": "This \"ClusterRole\" is allowed to \"GET\" and \"POST\" requests to the non-resource endpoint \"/healthz\" and all subpaths (must be in the \"ClusterRole\" bound with a \"ClusterRoleBinding\" to be effective).", | ||
| "Build from Dockerfile": "Build from Dockerfile", | ||
| "A Dockerfile build performs an image build using a Dockerfile in the source repository or specified in build configuration.": "A Dockerfile build performs an image build using a Dockerfile in the source repository or specified in build configuration.", | ||
| "Source-to-Image (S2I) build": "Source-to-Image (S2I) build", | ||
| "S2I is a tool for building reproducible container images. It produces ready-to-run images by injecting the application source into a container image and assembling a new image.": "S2I is a tool for building reproducible container images. It produces ready-to-run images by injecting the application source into a container image and assembling a new image.", | ||
| "Set compute resource quota": "Set compute resource quota", | ||
| "Limit the total amount of memory and CPU that can be used in a namespace.": "Limit the total amount of memory and CPU that can be used in a namespace.", | ||
| "Set maximum count for any resource": "Set maximum count for any resource", | ||
| "Restrict maximum count of each resource so users cannot create more than the allotted amount.": "Restrict maximum count of each resource so users cannot create more than the allotted amount.", | ||
| "Specify resource quotas for a given storage class": "Specify resource quotas for a given storage class", | ||
| "Limit the size and number of persistent volume claims that can be created with a storage class.": "Limit the size and number of persistent volume claims that can be created with a storage class.", | ||
| "Allow reading the resource in API group": "Allow reading the resource in API group", | ||
| "This \"Role\" is allowed to read the resource \"Pods\" in the core API group.": "This \"Role\" is allowed to read the resource \"Pods\" in the core API group.", | ||
| "Allow reading/writing the resource in API group": "Allow reading/writing the resource in API group", | ||
| "This \"Role\" is allowed to read and write the \"Deployments\" in both the \"extensions\" and \"apps\" API groups.": "This \"Role\" is allowed to read and write the \"Deployments\" in both the \"extensions\" and \"apps\" API groups.", | ||
| "Allow different access rights to different types of resource and API groups": "Allow different access rights to different types of resource and API groups", | ||
| "This \"Role\" is allowed to read \"Pods\" and read/write \"Jobs\" resources in API groups.": "This \"Role\" is allowed to read \"Pods\" and read/write \"Jobs\" resources in API groups.", | ||
| "Allow reading a ConfigMap in a specific namespace (for RoleBinding)": "Allow reading a ConfigMap in a specific namespace (for RoleBinding)", | ||
| "This \"Role\" is allowed to read a \"ConfigMap\" named \"my-config\" (must be bound with a \"RoleBinding\" to limit to a single \"ConfigMap\" in a single namespace).": "This \"Role\" is allowed to read a \"ConfigMap\" named \"my-config\" (must be bound with a \"RoleBinding\" to limit to a single \"ConfigMap\" in a single namespace).", | ||
| "Add a link to the user menu": "Add a link to the user menu", | ||
| "The user menu appears in the right side of the masthead below the username.": "The user menu appears in the right side of the masthead below the username.", | ||
| "Add a link to the application menu": "Add a link to the application menu", | ||
| "The application menu appears in the masthead below the 9x9 grid icon. Application menu links can include an optional image and section heading.": "The application menu appears in the masthead below the 9x9 grid icon. Application menu links can include an optional image and section heading.", | ||
| "Add a link to the namespace dashboard": "Add a link to the namespace dashboard", | ||
| "Namespace dashboard links appear on the project dashboard and namespace details pages in a section called \"Launcher\". Namespace dashboard links can optionally be restricted to a specific namespace or namespaces.": "Namespace dashboard links appear on the project dashboard and namespace details pages in a section called \"Launcher\". Namespace dashboard links can optionally be restricted to a specific namespace or namespaces.", | ||
| "Add a link to the contact mail": "Add a link to the contact mail", | ||
| "The contact mail link appears in the user menu below the username. The link will open the default email client with the email address filled in.": "The contact mail link appears in the user menu below the username. The link will open the default email client with the email address filled in.", | ||
| "Add catalog categories": "Add catalog categories", | ||
| "Provides a list of default categories which are shown in the Software Catalog. The categories must be added below customization developerCatalog.": "Provides a list of default categories which are shown in the Software Catalog. The categories must be added below customization developerCatalog.", | ||
| "Add project access roles": "Add project access roles", | ||
| "Provides a list of default roles which are shown in the Project Access. The roles must be added below customization projectAccess.": "Provides a list of default roles which are shown in the Project Access. The roles must be added below customization projectAccess.", | ||
| "Add page actions": "Add page actions", | ||
| "Provides a list of all available actions on the Add page in the Developer perspective. The IDs must be added below customization addPage disabledActions to hide these actions.": "Provides a list of all available actions on the Add page in the Developer perspective. The IDs must be added below customization addPage disabledActions to hide these actions.", | ||
| "Add sub-catalog types": "Add sub-catalog types", | ||
| "Provides a list of all the available sub-catalog types which are shown in the Software Catalog. The types must be added below spec customization developerCatalog": "Provides a list of all the available sub-catalog types which are shown in the Software Catalog. The types must be added below spec customization developerCatalog", | ||
| "Add user perspectives": "Add user perspectives", | ||
| "Provides a list of all the available user perspectives which are shown in the perspective dropdown. The perspectives must be added below spec customization.": "Provides a list of all the available user perspectives which are shown in the perspective dropdown. The perspectives must be added below spec customization.", | ||
| "Add pinned resources": "Add pinned resources", | ||
| "Provides a list of resources to be pinned on the Developer perspective navigation. The pinned resources must be added below spec customization perspectives.": "Provides a list of resources to be pinned on the Developer perspective navigation. The pinned resources must be added below spec customization perspectives.", | ||
| "Set maxUnavaliable to 0": "Set maxUnavaliable to 0", | ||
| "An eviction is allowed if at most 0 pods selected by \"selector\" are unavailable after the eviction.": "An eviction is allowed if at most 0 pods selected by \"selector\" are unavailable after the eviction.", | ||
| "Set minAvailable to 25%": "Set minAvailable to 25%", | ||
| "An eviction is allowed if at least 25% of pods selected by \"selector\" will still be available after the eviction.": "An eviction is allowed if at least 25% of pods selected by \"selector\" will still be available after the eviction.", | ||
| "Helm Release": "Helm Release", | ||
| "Name must consist of lower-case letters, numbers and hyphens. It must start with a letter and end with a letter or number.": "Name must consist of lower-case letters, numbers and hyphens. It must start with a letter and end with a letter or number.", | ||
| "Cannot be longer than {{characterCount}} characters.": "Cannot be longer than {{characterCount}} characters.", | ||
| "Required": "Required" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify JSON validity
echo "=== Checking JSON validity ==="
cat frontend/packages/console-shared/locales/en/console-shared.json | python3 -m json.tool > /dev/null && echo "JSON is valid" || echo "JSON is INVALID"
# Search for i18n configuration in the codebase
echo -e "\n=== Searching for i18n configuration files ==="
fd -type f \( -name "*i18n*" -o -name "*config*" \) | head -20
# Check for references to locale paths in TypeScript/JavaScript files
echo -e "\n=== Checking for references to console-shared locale ==="
rg -l 'console-shared' --type ts --type js | head -20
# Search for old public path references that should be removed
echo -e "\n=== Checking for stale references to old public/locales path ==="
rg 'public/locales.*console-shared|console-shared.*public/locales' || echo "No old path references found"
# Check for new package path references
echo -e "\n=== Checking for new package path references ==="
rg 'packages/console-shared.*locale|@console-shared.*locale' -n | head -20
# Verify the typo claim on line 312
echo -e "\n=== Checking line 312 for typo ==="
sed -n '312p' frontend/packages/console-shared/locales/en/console-shared.jsonRepository: openshift/console
Length of output: 147
🏁 Script executed:
#!/bin/bash
# First, verify the file exists and is valid JSON
echo "=== Checking file existence and JSON validity ==="
if [ -f "frontend/packages/console-shared/locales/en/console-shared.json" ]; then
echo "File exists"
python3 -c "import json; json.load(open('frontend/packages/console-shared/locales/en/console-shared.json'))" && echo "JSON is valid" || echo "JSON is INVALID"
else
echo "File not found"
fi
# Check line count to verify it's 320 lines as claimed
echo -e "\n=== Line count ==="
wc -l frontend/packages/console-shared/locales/en/console-shared.json
# Check the specific line with the alleged typo
echo -e "\n=== Checking for typo (line around 312) ==="
grep -n "maxUnav" frontend/packages/console-shared/locales/en/console-shared.json
# Check if old path exists
echo -e "\n=== Checking old path ==="
if [ -f "frontend/public/locales/en/console-shared.json" ]; then
echo "Old path still exists"
else
echo "Old path does not exist"
fiRepository: openshift/console
Length of output: 382
🏁 Script executed:
#!/bin/bash
# Search for i18n configuration and package.json files
echo "=== Checking package.json in console-shared ==="
if [ -f "frontend/packages/console-shared/package.json" ]; then
cat frontend/packages/console-shared/package.json | head -30
fi
# Search for i18n loader configuration
echo -e "\n=== Searching for i18n configuration or references ==="
rg -i 'locales|i18n' frontend/packages/console-shared/package.json 2>/dev/null || echo "No matches in package.json"
# Check for index or entry files that might export locales
echo -e "\n=== Checking for index files in console-shared ==="
ls -la frontend/packages/console-shared/ 2>/dev/null | head -20
# Search for how locale files are imported in the main console
echo -e "\n=== Searching for locale imports in main console ==="
rg 'console-shared' frontend/public/index.html 2>/dev/null | head -5
# Check webpack or build configuration
echo -e "\n=== Checking webpack configuration ==="
fd webpack.config.js | head -3
</parameter>Repository: openshift/console
Length of output: 1047
🏁 Script executed:
#!/bin/bash
# Search for how locales are imported/required across the codebase
echo "=== Searching for locale file imports ==="
rg -n "locales/en/console-shared" --type ts --type js | head -20
# Check if there's an index or export from console-shared
echo -e "\n=== Checking for locale exports in console-shared src ==="
ls -la frontend/packages/console-shared/src/ | head -20
# Search for i18n setup in main app
echo -e "\n=== Searching for i18n initialization ==="
rg -n "i18n\\.init|i18n\\.use|i18next" --type ts --type js | head -20
# Check locales directory structure
echo -e "\n=== Checking locales directory structure ==="
find frontend/packages/console-shared/locales -type f | head -20
# Search for any direct references to the locale file path
echo -e "\n=== Searching for direct locale file path references ==="
rg -n "packages/console-shared/locales" --type ts --type js --type json | head -20Repository: openshift/console
Length of output: 3602
🏁 Script executed:
#!/bin/bash
# Check the webpack configuration to see how locales are loaded
echo "=== Checking webpack.config.ts for locale loading ==="
sed -n '290,310p' frontend/webpack.config.ts
# Search for where i18n loads the locale files
echo -e "\n=== Searching for i18n.loadNamespace or locale loading patterns ==="
rg -n "loadNamespace|namespaces|console-shared" frontend/public/index.tsx frontend/public/index.html 2>/dev/null | head -20
# Check for dynamic locale file loading
echo -e "\n=== Searching for locale file loading mechanism ==="
rg -n "locales/" --type ts --type js -A 2 -B 2 | head -40
# Check if there's a manifest or namespace configuration
echo -e "\n=== Checking for i18n namespace configuration ==="
rg -n "console-shared|namespaces" frontend/public/i18n.ts frontend/public/init-plugins.ts 2>/dev/null | head -20Repository: openshift/console
Length of output: 4314
🏁 Script executed:
#!/bin/bash
# Check the i18n.js to understand how locales are loaded
echo "=== Checking i18n.js loading mechanism ==="
cat frontend/public/i18n.js | head -50
# Verify the consolidate-public-folders script to understand the build process
echo -e "\n=== Checking consolidation script ==="
cat frontend/i18n-scripts/consolidate-public-folders.jsRepository: openshift/console
Length of output: 4323
Fix typo: "maxUnavaliable" should be "maxUnavailable" on line 312.
The locale file relocation is properly configured in the webpack build (copy plugin includes the new path), and the i18n consolidation script will correctly merge these locales with the public locales during the build process. However, fix the misspelling in the PodDisruptionBudget description string.
🤖 Prompt for AI Agents
In @frontend/packages/console-shared/locales/en/console-shared.json around lines
1-320, Typo in the locale key "maxUnavaliable" (should be "maxUnavailable") —
update the JSON key/value to correct spelling. Locate the entry with the text
"Set maxUnavaliable to 0" (appearing in the PodDisruptionBudget description
block) and rename the key/value to "Set maxUnavailable to 0" and adjust any
related sentence occurrences ("maxUnavaliable" → "maxUnavailable") so i18n
lookups use the correct term.
| "Provides a list of all the available user perspectives which are shown in the perspective dropdown. The perspectives must be added below spec customization.": "Provides a list of all the available user perspectives which are shown in the perspective dropdown. The perspectives must be added below spec customization.", | ||
| "Add pinned resources": "Add pinned resources", | ||
| "Provides a list of resources to be pinned on the Developer perspective navigation. The pinned resources must be added below spec customization perspectives.": "Provides a list of resources to be pinned on the Developer perspective navigation. The pinned resources must be added below spec customization perspectives.", | ||
| "Set maxUnavaliable to 0": "Set maxUnavaliable to 0", |
There was a problem hiding this comment.
Fix typo in user-facing string.
The key contains a typo: "maxUnavaliable" should be "maxUnavailable".
🔎 Proposed fix
- "Set maxUnavaliable to 0": "An eviction is allowed if at most 0 pods selected by \"selector\" are unavailable after the eviction.",
+ "Set maxUnavailable to 0": "An eviction is allowed if at most 0 pods selected by \"selector\" are unavailable after the eviction.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Set maxUnavaliable to 0": "Set maxUnavaliable to 0", | |
| "Set maxUnavailable to 0": "Set maxUnavailable to 0", |
🤖 Prompt for AI Agents
In @frontend/packages/console-shared/locales/en/console-shared.json around line
312, The JSON entry "Set maxUnavaliable to 0" contains a typo; update the key
and its value to use the correct spelling "maxUnavailable" (i.e., change "Set
maxUnavaliable to 0" to "Set maxUnavailable to 0") so the user-facing string and
lookup key both reflect the correct term.
cajieh
force-pushed
the
revert-console-shared.json-console-shared-directory
branch
from
150349e to
14a55a1
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/verified later @yapei |
openshift-ci-robot
added
verified-later
verified
Contributor
|
@cajieh: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/test okd-scos-images |
Contributor
Contributor
Author
|
/test okd-scos-images |
1 similar comment
Contributor
Author
|
/test okd-scos-images |
Contributor
Member
|
/override ci/prow/okd-scos-images |
Contributor
|
@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/okd-scos-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jhadvig
added
the
plugin-api-approved
Member
|
/retest |
Contributor
Contributor
|
/hold Revision 14a55a1 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
|
/cancel hold |
Contributor
Author
|
/retest |
Contributor
Author
|
/test okd-scos-images |
Contributor
|
@cajieh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.