-
Notifications
You must be signed in to change notification settings - Fork 668
Support Service Binding breaking api changes in console #6422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Service Binding breaking api changes in console #6422
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akashshinde The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
|
Akash wouldn't we have a new channel for this? |
Yes, that is the idea so that we can avoid breaking existing 4.5 clusters. |
|
@akashshinde: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@akashshinde: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
solved in #6792 |
|
/close |
|
@pedjak: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR isn't meant to be merged, this is just to illustrate what changes UI needs to make in order to make use of updated Service Binding API.
Ref: Backed PR for this redhat-developer/service-binding-operator#608
Note:
This changes would cause problem when user wants to use latest Service Binding Operator with Openshift 4.5 or previous versions, because DevConsole would still create older version of Service Binding Request which won't be supported if latest version of SBO is installed.
To fix this issues user can install SBO using different channel(This is being discussed how to use different channel to serve different version of SBO). This will be clearly documented in SBO repo. wdyt @sbose78 ? cc: @pedjak