Skip to content

Conversation

@akashshinde
Copy link
Contributor

This PR isn't meant to be merged, this is just to illustrate what changes UI needs to make in order to make use of updated Service Binding API.

Ref: Backed PR for this redhat-developer/service-binding-operator#608

Note:
This changes would cause problem when user wants to use latest Service Binding Operator with Openshift 4.5 or previous versions, because DevConsole would still create older version of Service Binding Request which won't be supported if latest version of SBO is installed.
To fix this issues user can install SBO using different channel(This is being discussed how to use different channel to serve different version of SBO). This will be clearly documented in SBO repo. wdyt @sbose78 ? cc: @pedjak

@akashshinde akashshinde changed the title Supporting Service Binding breaking api changes in console Support Service Binding breaking api changes in console Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akashshinde
To complete the pull request process, please assign andrewballantyne
You can assign the PR to them by writing /assign @andrewballantyne in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 25, 2020
@akashshinde akashshinde marked this pull request as draft August 25, 2020 05:02
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020
@pedjak
Copy link
Contributor

pedjak commented Aug 25, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@sbose78
Copy link

sbose78 commented Aug 25, 2020

Akash wouldn't we have a new channel for this?

@pedjak
Copy link
Contributor

pedjak commented Aug 26, 2020

Akash wouldn't we have a new channel for this?

Yes, that is the idea so that we can avoid breaking existing 4.5 clusters.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@akashshinde: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@akashshinde: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin a19909a link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pedjak
Copy link
Contributor

pedjak commented Oct 20, 2020

solved in #6792

@pedjak
Copy link
Contributor

pedjak commented Oct 20, 2020

/close

@openshift-ci-robot
Copy link
Contributor

@pedjak: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dev-console Related to dev-console do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants