OCPBUGS-59105: pkg/asset/manifests/azure: save cidr blocks

[jhixson74]

When using a pre-existing network, save CIDR blocks for the virtual network and subnets

https://issues.redhat.com/browse/OCPBUGS-59105

[openshift-ci-robot]

@jhixson74: This pull request references Jira Issue OCPBUGS-59105, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When using a pre-existing network, save CIDR blocks for the virtual network and subnets

https://issues.redhat.com/browse/OCPBUGS-59105

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhixson74]

/jira refresh

[openshift-ci-robot]

@jhixson74: This pull request references Jira Issue OCPBUGS-59105, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhixson74]

/retest-required

[rna-afk]

I am doing most of this in #9773 . Any chance we could merge this with that work?

[jinyunma]

pre-merge tested, installation with pre-created vnet (network configuration was same with bug) succeeded.
Also did regression test, no issues were found.

/verified by jima

[openshift-ci-robot]

@jinyunma: This PR has been marked as verified by jima.

In response to this:

pre-merge tested, installation with pre-created vnet (network configuration was same with bug) succeeded.
Also did regression test, no issues were found.

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

I just have a small question above ⬆️ and ci/prow/golint is current not happy 😓 Maybe it prefers make([]slice, len) and a bit other simplification.

There is also a comment from Aditya #10034 (comment) 👀

[jhixson74]

I am doing most of this in #9773 . Any chance we could merge this with that work?

I haven't been following your work here very closely. I'll review it tomorrow. It does look quite a bit more involved than what I've done here though.

[openshift-ci]

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-shared-vpc	2d4fcd7	link	false	/test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack	2d4fcd7	link	false	/test e2e-azurestack
ci/prow/okd-scos-e2e-aws-ovn	2d4fcd7	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

/lgtm

Code looks good to me!

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/asset/manifests/azure/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhixson74]

/retest-required

[jinyunma]

Retested with latest change, installation with pre-created vnet (network configuration was same with bug) succeeded, and regression tests also passed, no other issues were detected.

/verified by jima

[openshift-ci-robot]

@jinyunma: This PR has been marked as verified by jima.

In response to this:

Retested with latest change, installation with pre-created vnet (network configuration was same with bug) succeeded, and regression tests also passed, no other issues were detected.

/verified by jima

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhixson74]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5b7289b and 2 for PR HEAD 2d4fcd7 in total

[tthvo]

/test gofmt golint

[openshift-ci-robot]

@jhixson74: Jira Issue Verification Checks: Jira Issue OCPBUGS-59105
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-59105 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

When using a pre-existing network, save CIDR blocks for the virtual network and subnets

https://issues.redhat.com/browse/OCPBUGS-59105

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.21.0-0.nightly-2025-11-22-193140