-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-63028: filtering only PEs from cluster list #10193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-63028, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-63028, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
703b1a7 to
ea74870
Compare
|
/retest-required |
|
/verified by @sgaoshang |
|
@sgaoshang: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@abhay-nutanix: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@abhay-nutanix the cluster didn't bootstrap and you confirm that this pr isn't the cause, thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem
The OpenShift installer fails with the following error when creating an install-config for Nutanix environments where Prism Central and Prism Element clusters share the same name:
FATAL failed to fetch Install Config: failed to fetch dependency of "Install Config": failed to fetch dependency of "Base Domain": failed to generate asset "Platform": missing ExternalIP in Prism Element network spec for "Development-LTS2"
Root Cause
The Nutanix v3 API's ListAllCluster endpoint returns both Prism Element (PE) and Prism Central (PC) clusters. The installer's getPrismElement() function did not distinguish between these cluster types.
If a Prism Element and Prism Central share the same name, the Prism Central entry overwrites the Prism Element entry in the map. Since Prism Central clusters typically don't have an ExternalIP configured in their network specification, selecting that cluster results in the "missing ExternalIP" error.
Solution
Modified pkg/asset/installconfig/nutanix/nutanix.go to filter out Prism Central clusters before presenting options to the user. The filtering logic:
Inspects the service_list field in each cluster's status
Excludes any cluster with "PRISM_CENTRAL" in its service list
Only presents Prism Element clusters (those with "AOS" or other non-PC services)
The implementation includes defensive nil checks to handle clusters with incomplete metadata gracefully.