OCPBUGS-70255: backwards compact for S3 API call

[tthvo]

Recently, the AWS SDK v2 introduces a new data integrity mechanism that enables checksum for PUT/GET calls by default using CRC32 algorithm [0]. This is "technically" a breaking change in behaviour.

Thus, this PR aims to restore the previous settings for backwards compactibility.

• Only enable checksums when the API call type requires it (i.e. batch delete objects)
• Set the algorithm type to MD5 for delete calls
• The destroy code is still on SDK v1 so no changes required.

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-70255, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Recently, the AWS SDK v2 introduces a new data integrity mechanism that enables checksum for PUT/GET calls by default using CRC32 algorithm [0]. This is "technically" a breaking change in behaviour.

Thus, this PR aims to restore the previous settings for backwards compactibility.

• Only enable checksums when the API call type requires it (i.e. batch delete objects)
• Set the algorithm type to MD5 for delete calls
• The destroy code is still on SDK v1 so no changes required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tthvo]

/label platform/aws
/hold
/cc @patrickdillon

[tthvo]

/cc @yunjiang29

[openshift-ci]

@tthvo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones	6a1966b	link	false	/test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-heterogeneous	6a1966b	link	false	/test e2e-aws-ovn-heterogeneous
ci/prow/okd-scos-images	6a1966b	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

Looks like manual testing of this is blocked as our access to the SHIFT emulator has expired.