[release-4.18] OCPBUGS-53235: Validation for API and Ingress VIPs when using user-managed load balancer #9618
Conversation
…balancers - Previously, when API and Ingress VIPs were not specified, default values were automatically generated for user-managed load balancers.This was unintended behavior. Now, if the user does not explicitly provide API and Ingress VIPs, a fatal error is thrown instead.
-If no load balancer is provided, a default OpenShift load balancer is now assigned automatically. This ensures proper handling and avoids misconfigurations.
Adds unit tests in platform_test.py to verify OpenStack platform defaults. Covers cases such as: - Assigning a default OpenShift-managed load balancer when none is specified - Handling user-managed load balancers with and without VIPs - Ensuring correct API and Ingress VIP assignments
- lb-default-stable: As a default load balancer is now being assigned when one is not provided this test needs to be updated to reflect that change - lb-unmanaged: I made changes to how the defaults are set. If the load balancer is user-managed VIPs will not automatically be assigned anymore. This change needs to be reflected in this test by adding a apiVIPs and ingressVIPs value to the install-config
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-53140 with correct target version. Will retitle the PR to link to the clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53235, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/retest |
1 similar comment
|
/retest |
|
/jira refresh |
openshift-ci-robot
added
jira/severity-low
|
@sadasu: This pull request references Jira Issue OCPBUGS-53235, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
/label backport-risk-assessed |
openshift-ci
bot
added
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
|
@dkokkino: This pull request references Jira Issue OCPBUGS-53235, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
| loadBalancer: | ||
| type: UserManaged | ||
| apiVIPs: | ||
| - 10.0.128.10 |
There was a problem hiding this comment.
| - 10.0.128.10 | |
| - 10.0.128.10 |
| apiVIPs: | ||
| - 10.0.128.10 | ||
| ingressVIPs: | ||
| - 10.0.128.20 |
There was a problem hiding this comment.
| - 10.0.128.20 | |
| - 10.0.128.20 |
|
/test yaml-lint |
|
/test ci/prow/yaml-lint |
|
@sadasu: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-openstack-externallb |
|
/retest |
|
/close in favour of #10046, which includes the YAML fix (I can't push to the |
|
@stephenfin: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-53235. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
9 participants
This is an automated cherry-pick of #9571
/assign openshift-ci-robot