-
Notifications
You must be signed in to change notification settings - Fork 247
CNTRLPLANE-1724: Add OTE helper functions in test/library/ote #2050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangwgr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gangwgr: This pull request references CNTRLPLANE-1724 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Discussion in slack for this: https://redhat-internal.slack.com/archives/CC3CZCQHM/p1762941938449059?thread_ts=1762421042.028719&cid=CC3CZCQHM |
Add two new OTE helper functions for common test scenarios:
1. WaitForAPIServerRollout: Waits for all API server pods to be recreated
after a configuration change. Unlike WaitForAPIServerToStabilizeOnTheSameRevision,
this specifically waits for NEW pods to replace old ones.
2. WaitForFeatureGateEnabled: Waits for a specific feature gate to be enabled
in the cluster by polling the FeatureGate resource.
These functions are needed for testing configuration changes and feature gate
enablement in operator e2e tests, particularly for EventTTL configuration tests
in cluster-kube-apiserver-operator.
|
@gangwgr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Moved funcs to test. I checked existing funcs have different behaviour |
Add two new OTE helper functions for common test scenarios:
WaitForAPIServerRollout: Waits for all API server pods to be recreated after a configuration change. Unlike WaitForAPIServerToStabilizeOnTheSameRevision, this specifically waits for NEW pods to replace old ones.
WaitForFeatureGateEnabled: Waits for a specific feature gate to be enabled in the cluster by polling the FeatureGate resource.
These functions are needed for testing configuration changes and feature gate
enablement in operator e2e tests, particularly for EventTTL configuration tests
in cluster-kube-apiserver-operator.