Skip to content

Conversation

@gangwgr
Copy link

@gangwgr gangwgr commented Nov 13, 2025

Add two new OTE helper functions for common test scenarios:

  1. WaitForAPIServerRollout: Waits for all API server pods to be recreated after a configuration change. Unlike WaitForAPIServerToStabilizeOnTheSameRevision, this specifically waits for NEW pods to replace old ones.

  2. WaitForFeatureGateEnabled: Waits for a specific feature gate to be enabled in the cluster by polling the FeatureGate resource.

These functions are needed for testing configuration changes and feature gate
enablement in operator e2e tests, particularly for EventTTL configuration tests
in cluster-kube-apiserver-operator.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gangwgr gangwgr marked this pull request as ready for review November 13, 2025 14:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@gangwgr gangwgr changed the title Add OTE helper functions in test/library/ote CNTRLPLANE-1724: Add OTE helper functions in test/library/ote Nov 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

@gangwgr: This pull request references CNTRLPLANE-1724 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Add two new OTE helper functions for common test scenarios:

  1. WaitForAPIServerRollout: Waits for all API server pods to be recreated after a configuration change. Unlike WaitForAPIServerToStabilizeOnTheSameRevision, this specifically waits for NEW pods to replace old ones.

  2. WaitForFeatureGateEnabled: Waits for a specific feature gate to be enabled in the cluster by polling the FeatureGate resource.

These functions are needed for testing configuration changes and feature gate
enablement in operator e2e tests, particularly for EventTTL configuration tests
in cluster-kube-apiserver-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor

wangke19 commented Nov 19, 2025

Discussion in slack for this: https://redhat-internal.slack.com/archives/CC3CZCQHM/p1762941938449059?thread_ts=1762421042.028719&cid=CC3CZCQHM
https://github.com/openshift/library-go/tree/master/test would hold test helpers we use to create test cases across our repositories
https://github.com/openshift/library-go/blob/master/test/library/apiserver/apiserver.go we have similar func.

  Add two new OTE helper functions for common test scenarios:

  1. WaitForAPIServerRollout: Waits for all API server pods to be recreated
     after a configuration change. Unlike WaitForAPIServerToStabilizeOnTheSameRevision,
     this specifically waits for NEW pods to replace old ones.

  2. WaitForFeatureGateEnabled: Waits for a specific feature gate to be enabled
     in the cluster by polling the FeatureGate resource.

  These functions are needed for testing configuration changes and feature gate
  enablement in operator e2e tests, particularly for EventTTL configuration tests
  in cluster-kube-apiserver-operator.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr
Copy link
Author

gangwgr commented Nov 19, 2025

Discussion in slack for this: https://redhat-internal.slack.com/archives/CC3CZCQHM/p1762941938449059?thread_ts=1762421042.028719&cid=CC3CZCQHM https://github.com/openshift/library-go/tree/master/test would hold test helpers we use to create test cases across our repositories https://github.com/openshift/library-go/blob/master/test/library/apiserver/apiserver.go we have similar func.

Moved funcs to test. I checked existing funcs have different behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants