Skip to content

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Oct 28, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@kyoto kyoto force-pushed the tests-fix-skip-tour branch from 3dbbc15 to e041fd8 Compare October 28, 2025 23:53
@kyoto kyoto changed the title [WIP] Tests: Fix skip tour action to run for all login options Tests: Fix skip tour action to run for all login options Oct 28, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@kyoto
Copy link
Member Author

kyoto commented Oct 29, 2025

/cherry-pick pattern-fly-5

@openshift-cherrypick-robot

@kyoto: once the present PR merges, I will cherry-pick it on top of pattern-fly-5 in a new PR and assign it to you.

In response to this:

/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyoto kyoto added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto
Copy link
Member Author

kyoto commented Oct 29, 2025

Override test failure unrelated to this change:
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console"

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

@kyoto: Overrode contexts on behalf of kyoto: Red Hat Konflux / e2e-console-pf6 / lightspeed-console

In response to this:

Override test failure unrelated to this change:
/override "Red Hat Konflux / e2e-console-pf6 / lightspeed-console"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 323e679 into openshift:main Oct 29, 2025
9 of 10 checks passed
@openshift-cherrypick-robot

@kyoto: #1097 failed to apply on top of branch "pattern-fly-5":

Applying: Tests: Fix skip tour action to run for all login options
Using index info to reconstruct a base tree...
M	cypress/support/commands.ts
M	tests/tests/lightspeed-install.cy.ts
Falling back to patching base and 3-way merge...
Auto-merging tests/tests/lightspeed-install.cy.ts
CONFLICT (content): Merge conflict in tests/tests/lightspeed-install.cy.ts
Auto-merging cypress/support/commands.ts
CONFLICT (content): Merge conflict in cypress/support/commands.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Tests: Fix skip tour action to run for all login options

In response to this:

/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyoto kyoto deleted the tests-fix-skip-tour branch October 29, 2025 05:20
@kyoto
Copy link
Member Author

kyoto commented Oct 29, 2025

Actually, the cherry pick to the pattern-fly-5 branch is not needed because the pattern-fly-5 branch tests run on OCP 4.17, which does not have the tour popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants