OU-1004: List perses dashbaords #666
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request references OU-1004 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
2 times, most recently
from
36881db to
be8bd6c
Compare
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
from
27f7498 to
2648502
Compare
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
2 times, most recently
from
02614bc to
fe7041f
Compare
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
from
6c5da8d to
fa6da57
Compare
There was a problem hiding this comment.
It seems we have 2 files called datasource-api.ts
There was a problem hiding this comment.
I renamed one of the files to differentiate them. /web/src/components/dashboards/perses/perses/datasource-cache-api.ts
| name: entity.metadata.name, | ||
| }); | ||
|
|
||
| const response = await consoleFetch(url, { |
There was a problem hiding this comment.
The console fetch has a put method, so we don't have to set the method manually
There was a problem hiding this comment.
Updated to use consoleFetchJSON.put(...).
| mutationFn: (dashboard) => { | ||
| return updateDashboard(dashboard); | ||
| }, |
There was a problem hiding this comment.
| mutationFn: (dashboard) => { | |
| return updateDashboard(dashboard); | |
| }, | |
| mutationFn: updateDashboard, |
| const HTTPMethodPUT = 'PUT'; | ||
| const HTTPHeader: Record<string, string> = { | ||
| 'Content-Type': 'application/json', | ||
| Accept: 'application/json', |
There was a problem hiding this comment.
we should use the consoleFetchJSON, please explore the SDK types this will allow you to see what is available and how to use it
There was a problem hiding this comment.
Updated to use consoleFetchJSON.put(...).
| defaultOptions: { | ||
| queries: { | ||
| refetchOnWindowFocus: false, | ||
| retry: 0, |
There was a problem hiding this comment.
should this be retry: false?
There was a problem hiding this comment.
Yes, this can be false instead of 0. I updated it in the latest commit.
| sortBy && direction | ||
| ? [...data].sort((a, b) => { | ||
| let aValue: any; | ||
| let bValue: any; | ||
|
|
||
| if (sortBy === 'name') { | ||
| aValue = a.name.label; | ||
| bValue = b.name.label; | ||
| } else if (sortBy === 'created') { | ||
| aValue = a.createdAt; | ||
| bValue = b.createdAt; | ||
| } else if (sortBy === 'modified') { | ||
| aValue = a.updatedAt; | ||
| bValue = b.updatedAt; | ||
| } else { | ||
| aValue = a[sortBy]; | ||
| bValue = b[sortBy]; | ||
| } | ||
|
|
||
| if (direction === 'asc') { | ||
| return aValue < bValue ? -1 : aValue > bValue ? 1 : 0; | ||
| } else { | ||
| return aValue > bValue ? -1 : aValue < bValue ? 1 : 0; | ||
| } | ||
| }) | ||
| : data; |
There was a problem hiding this comment.
This function will be more readable and maintainable with an early exit:
if(!sortBy || !direction) return data;
There was a problem hiding this comment.
Yes, this makes it much more readable. Updated in the latest commit.
zhuje
force-pushed
the
ou1004-list-dashboards-pr
branch
from
610f670 to
9a9d158
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
JIRA
https://issues.redhat.com/browse/OU-1004
ou1004-list-perses-dashboards.mov