OU-1082: claude slash commands cypress-setup and cypress-run #673
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@etmurasaki: This pull request references OU-1082 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etmurasaki The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@etmurasaki: This pull request references OU-1082 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
e2e-monitoring results run successfully with a known bug OU-1118 not merged in this PR /override pull-ci-openshift-monitoring-plugin-main-e2e-monitoring |
|
@etmurasaki: Overrode contexts on behalf of etmurasaki: ci/prow/e2e-monitoring DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@etmurasaki: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| --- | ||
|
|
||
| ## Execution Flow |
There was a problem hiding this comment.
For my this failed as it was trying to execute the command in the claude code terminal, instead of opening a new one. Maybe it will be better to be more explicit that a new terminal should be opened and the script should be executed there. Also maybe we don't need to embeed the whole script in the command but in a different folder and point the command to it.
|
|
||
| ## ⚡ Quick Start - Headless | ||
|
|
||
| **Fast Smoke Test (1-2 min, excludes slow/demo/flaky):** |
There was a problem hiding this comment.
For convenienve, we can tell claude to allow the user to select from this list of tests, and execute the appropriate command based on the selection
DavidRajnoha
left a comment
DavidRajnoha
left a comment
There was a problem hiding this comment.
Besides the comments in the code, I have two questions:
- What is the validation in the cypress-setup exactly performing?
- How do you pass the variables (base url, kubeadmin passwd,...) to it? Should you include them when running the command?
|
|
||
| --- | ||
|
|
||
| ## 🎯 Execution Modes |
There was a problem hiding this comment.
Can we discuss the inclussion of the AI emojis in the docs / commands? Do we want them? I would vote for no, I don't think they add significant value / readability improvement and are visual clutter.
|
|
||
| --- | ||
|
|
||
| ## 🎪 Specific Test Files - Headless |
There was a problem hiding this comment.
Should the specific test files be here? I see a huge risk of this being inconsistent when things start changing and we won't update this.
|
|
||
| echo "" | ||
| echo "Configured values:" | ||
| echo " CYPRESS_BASE_URL=$CYPRESS_BASE_URL" |
There was a problem hiding this comment.
What is the reason of this and following changes? What should they achieve?
There was a problem hiding this comment.
initially I was not using this shell, but then started using it during the setup command and noticed it was not working in my mac due to bash version... with this solved, I got other error
./configure-env.sh: line 545: CYPRESS_BASE_URL: unbound variable
so I started asking claude to solve it and the intention of these both slash commands were to setup a new terminal window (that I am mostly using claude code in the terminal inside cursor/vscode), and execute there, to free up the terminal/claude code from controlling and executing it inside the IDE...
|
|
||
| # [3/4] Create setup script | ||
| echo "[3/4] Creating setup script..." | ||
| TEMP_SCRIPT="/tmp/cypress-setup-$$.sh" |
There was a problem hiding this comment.
Is there a need to generate those scripts on every run instead of having them defined as .sh file and referencing that? In my opinion it makes quite complicated to understand the scope/function of this setup-command.sh
4 participants
Creation of 2 claude slash commands:
/cypress-setupand/cypress-runWhen running
/cypress-setup, it validates the pre-reqs and opens a new terminal to prepare it with all cypress variables needed, such as base URL, credentials, kubeconfig etc.Then
/cypress-runwill print to you all available commands for you to copy and paste in the opened terminal you had.This way, will make claude available to perform other things instead of running and controlling the testing execution.