Skip to content

Conversation

@PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Dec 17, 2025

In some refactoring caused the poll interval to somehow got multiplied by the default poll interval value rather than using it if the state isn't set.

Since the default state is now set by the store definition, the default poll interval is no longer needed here at all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@PeterYurkovich PeterYurkovich changed the title fix: remove random multiplication OU-1088: remove random multiplication Dec 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2025

@PeterYurkovich: This pull request references OU-1088 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

In some refactoring the poll interval somehow got multiplied by the default poll interval value rather than using it if the state isn't set.

Since the default state is now set by the store definition, the default poll interval is no longer needed here at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2025

@PeterYurkovich: This pull request references OU-1088 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

In some refactoring caused the poll interval to somehow got multiplied by the default poll interval value rather than using it if the state isn't set.

Since the default state is now set by the store definition, the default poll interval is no longer needed here at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@etmurasaki
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2025

@PeterYurkovich: This pull request references OU-1088 which is a valid jira issue.

Details

In response to this:

In some refactoring caused the poll interval to somehow got multiplied by the default poll interval value rather than using it if the state isn't set.

Since the default state is now set by the store definition, the default poll interval is no longer needed here at all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgbernalp
Copy link
Contributor

/lgtm

@jgbernalp
Copy link
Contributor

/override ci/prow/okd-scos-images

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 96a52b2 into openshift:main Dec 18, 2025
9 checks passed
@PeterYurkovich
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@PeterYurkovich: new pull request created: #703

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants