Skip to content

Conversation

@rioloc
Copy link
Member

@rioloc rioloc commented Dec 18, 2025

This PR introduces the following change for the Incident component:

  • The UI always load data for 15 days with a single query_range call, instead of having a call per day. This is achieved by changing the getIncidentsTimeRanges function.
  • IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Video recording

recording.1.webm

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

  • The UI always load data for 15 days with a single query_range call, instead of having a call per day. This is achieved by changing the getIncidentsTimeRanges function.
  • IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rioloc
Once this PR has been reviewed and has the lgtm label, please assign zhuje for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@rioloc: This pull request references OU-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces the following change for the Incident component:

  • The UI always load data for 15 days with a single query_range call, instead of having a call per day. This is achieved by changing the getIncidentsTimeRanges function.
  • IncidentsChart and AlertsChart have been updated to filter out, from the 15 days data, the one which are not in currentTime - Last N Days

Before

By downloading only datapoints for "Last N Days" the displayed Start date would be relative to N days

After

Start displays an absolute date, even when Last N Days is far in the future rather than the start date

Video recording

recording.1.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants