-
Notifications
You must be signed in to change notification settings - Fork 53
Update ovn-db-run-locally #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Missing a dot(.) to correctly point to the utils file in below folder
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RH-csaggin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Forced podman pull with [--arch=amd64] option to make it compatible with macOS
added missing dot(.) form source utils
| fi | ||
|
|
||
| CONTAINER=$($CONTAINER_ENGINE run -t -d --entrypoint /bin/bash quay.io/openshift/origin-ovn-kubernetes:latest) | ||
| CONTAINER=$($CONTAINER_ENGINE run --arch=amd64 -t -d --entrypoint /bin/bash quay.io/openshift/origin-ovn-kubernetes:latest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to adapt this to run in MacOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which should not affect any other OS as there are not other images arch
|
Any update on this @zshi-redhat @s1061123 ? |
|
@RH-csaggin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Missing a dot(.) to correctly point to the utils file in below folder