Skip to content

[oadp-1.5] set skip-tls default to true #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Feb 9, 2026
Merged

[oadp-1.5] set skip-tls default to true #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932f150
set skip-tls default to true
weshayutin Sep 25, 2025
f04f030
update comment for insecure
weshayutin Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

func init() {
pkg.CLI.Flags().DurationVarP(&pkg.RequestTimeout, "request-timeout", "r", pkg.DefaultRequestTimeout, "Timeout per OADP server request (like collecting logs from a backup)")
pkg.CLI.Flags().BoolVarP(&pkg.SkipTLS, "skip-tls", "s", false, "Run OADP server requests with insecure TLS connections (recommended if a custom CA certificate is used) (default false)")
pkg.CLI.Flags().BoolVarP(&pkg.SkipTLS, "skip-tls", "s", true, "Run OADP server requests with insecure TLS connections (recommended if a custom CA certificate is used) (default true)")
// TODO caCertFile?
pkg.CLI.Flags().BoolP("help", "h", false, "Show OADP Must-gather help message.")

Expand Down
4 changes: 2 additions & 2 deletions pkg/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ var (

For more information, check OADP must-gather documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/backup_and_restore/oadp-application-backup-and-restore#using-the-must-gather-tool`,
Args: cobra.NoArgs,
Example: fmt.Sprintf(` # running OADP Must-gather with default configuration
Example: fmt.Sprintf(` # running OADP Must-gather with default configuration (insecure TLS connections enabled by default)
oc adm must-gather --image=%[1]s

# running OADP Must-gather with timeout of 1 minute per OADP server request
oc adm must-gather --image=%[1]s -- /usr/bin/gather --request-timeout 1m

# running OADP Must-gather with timeout of 15 seconds per OADP server request and with insecure TLS connections
oc adm must-gather --image=%[1]s -- /usr/bin/gather --request-timeout 15s --skip-tls`, mustGatherImage),
oc adm must-gather --image=%[1]s -- /usr/bin/gather --request-timeout 15s`, mustGatherImage),
SilenceErrors: true,
SilenceUsage: true,
RunE: func(_ *cobra.Command, _ []string) error {
Expand Down