OADP-7143: update runc requirement#78
Conversation
|
@weshayutin: This pull request references OADP-7143 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| replace github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.12 |
There was a problem hiding this comment.
I would not recommend using replace for this.
https://www.perplexity.ai/search/for-this-should-we-use-go-get-SGN5yzckSj.zb9VDYTeTcw#0
There was a problem hiding this comment.
even so.. 1.1.12 is the version already used at base branch... and is not new enough to contain the patched versions mentioned in advisory.
There was a problem hiding this comment.
Since we have no direct dependency on runc (it's not in go.mod) this is technically a false positive report.
ie.. this is based off go sum and not go mod.
No description provided.