NO-JIRA: Update shellescape and sspi to newer versions

[ardaguclu]

• shellescape has been moved to new domain al.essio.dev/pkg/shellescape. This PR updates the version and domain name of this package.
• sspi has been released new version due to some new constraints in Azure (Add channel binding support to SSPI context updates alexbrainman/sspi#18). This PR updates it to newer version.
  • If we get bug reports about oc login does not work on Windows or against Azure, I'm linking this referenced PR Add RFC 5929 channel binding support for SSPI client go-ldap/ldap#565 to be an example for us how we can adopt changes for channel binding.

Note: I tried to migrate from archived github.com/gonum/graph to gonum.org/v1/gonum. But it requires some major changes. So I'll defer this for now as a very nice to have in the future.

[openshift-ci-robot]

@ardaguclu: This pull request explicitly references no jira issue.

In response to this:

• shellescape has been moved to new domain al.essio.dev/pkg/shellescape. This PR updates the version and domain name of this package.
• sspi has been released new version due to some new constraints in Azure (Add channel binding support to SSPI context updates alexbrainman/sspi#18). This PR updates it to newer version.
• If we get bug reports about oc login does not work on Windows or against Azure, I'm linking this referenced PR Add RFC 5929 channel binding support for SSPI client go-ldap/ldap#565 to be an example for us how we can adopt changes for channel binding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Updated dependencies in go.mod: replaced github.com/alessio/shellescape with al.essio.dev/pkg/shellescape and bumped github.com/alexbrainman/sspi version. Adjusted one Go file to use the new shellescape import path. No functional or API changes indicated.

Changes

Cohort / File(s)	Summary
Dependency updates go.mod	Added al.essio.dev/pkg/shellescape@v1.6.0, removed github.com/alessio/shellescape@v1.4.1, updated github.com/alexbrainman/sspi to v0.0.0-20250919150558-7d374ff0d59e.
Import path migration pkg/cli/admin/copytonode/copy_to_node.go	Switched import from github.com/alessio/shellescape to al.essio.dev/pkg/shellescape; no code logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title clearly identifies the primary changes, namely updating the shellescape and sspi dependencies, and does so concisely without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	The pull request description explicitly outlines updating the shellescape package path to its new domain and bumping the sspi dependency with a link to the relevant upstream pull request addressing Azure constraints, which directly corresponds to the modifications in go.mod and import statements. It also includes context for potential future work and guidance for related debugging, making it clearly relevant and informative for reviewers. The details align with the raw summary of changes and objectives, confirming that the description accurately captures the scope and intent of the pull request.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ardaguclu]

/hold
until reviewed
/cc @tchap
could you PTAL?.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between a25e854 and 5bb9e8c.

⛔ Files ignored due to path filters (15)

• go.sum is excluded by !**/*.sum
• vendor/al.essio.dev/pkg/shellescape/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/.golangci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/.goreleaser.yml is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/AUTHORS is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/CODE_OF_CONDUCT.md is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/Makefile is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/al.essio.dev/pkg/shellescape/shellescape.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alessio/shellescape/.goreleaser.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alessio/shellescape/CODE_OF_CONDUCT.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alexbrainman/sspi/internal/common/common.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alexbrainman/sspi/syscall.go is excluded by !vendor/**, !**/vendor/**
• vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (2)

• go.mod (1 hunks)
• pkg/cli/admin/copytonode/copy_to_node.go (1 hunks)

🔇 Additional comments (1)

pkg/cli/admin/copytonode/copy_to_node.go (1)

14-14: Import path update to the new module domain is correct

The vanity path switch lines up with the v1.6.0 module and the Quote/QuoteCommand APIs in use remain stable, so no call-site adjustments are needed. Based on learnings

[tchap]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

I think, we don't have to verify this manually. If CI is green, we are ok.
/verify bypass

[ardaguclu]

/verified bypass

[openshift-ci-robot]

@ardaguclu: The verified label has been added.

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

/hold cancel

[openshift-ci]

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	5bb9e8c	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Neustradamus]

@ardaguclu: Thanks for your update!

Linked to:

• Channel Binding: State of Play scram-sasl/info#1