-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-12099#Add CLI cmd for PVC usage #90971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM but i would prefer to avoid showing internal namespace references such as clusters-hypershift-ci-339424 |
lahinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one nit and a couple of comments for your consideration.
|
LGTM thanks! |
|
Should we need to add the execution steps for kubeadmin/normal user privilages which is mentioned in doc: https://docs.google.com/document/d/1QAWt6ZEnUbWJ66-nycyhivNij5Md656nONXdvPhYPKs/edit?disco=AAABgFGCobw |
|
is it specific to ROSA ? if so maybe it can be added to the rosa doc and linked from here? |
Hi Gregory, The execution steps mentioned under limitations 1 and 2 in doc is on all OCP/ROSA clusters. |
Agreed, it would be helpful to include these steps. Setting KUBECONFIG is not enough, you have to be logged in either as admin or as a user with an appropriate clusterrole. |
I think I have this documented now. PTAL @dobsonj @tsmetana @gcharot @ropatil010 |
|
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM! |
|
LGTM, Thanks. |
tsmetana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherrypick enterprise-4.19 |
|
@lpettyjo: new pull request created: #93183 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/OSDOCS-12099
Link to docs preview: https://90971--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html#pvc-cli-command-usage_understanding-persistent-storage
QE review:
Additional information:
PTAL: @dobsonj @tsmetana @gcharot @ropatil010