TELCODOCS-2099: Support for dual-port ordinary clock in PTP #91166

rohennes · 2025-03-27T12:17:06Z

TELCODOCS-2099: Support for dual-port ordinary clock in PTP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2099

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2025-03-27T12:17:10Z

@rohennes: This pull request references TELCODOCS-2099 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

TELCODOCS-2099: Support for dual-port ordinary clock in PTP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2099

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-03-27T12:24:40Z

🤖 Wed Apr 09 10:45:36 - Prow CI generated the docs preview:

https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/about-ptp.html
https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/configuring-ptp.html

openshift-ci-robot · 2025-03-28T15:34:08Z

@rohennes: This pull request references TELCODOCS-2099 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

TELCODOCS-2099: Support for dual-port ordinary clock in PTP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2099

Link to docs preview:

https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/about-ptp.html#ptp-dual-ports-oc_about-ptp

https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/configuring-ptp.html#configuring-linuxptp-services-oc-dual-port_configuring-ptp

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

edcdavid · 2025-03-31T14:04:59Z

modules/ptp-dual-ports-oc.adoc

+
+[NOTE]
+====
+You must configure the NVIDIA BlueField-3 series DPU in NIC mode before configuring the interface as an ordinary clock with improved redundancy. For further information about configuring NIC mode, see link:https://docs.nvidia.com/networking/display/bluefielddpubspv422/modes+of+operation#src-141856548_ModesofOperation-NICModeforBlueField-3[NIC Mode for BlueField-3] (NVIDIA documentation).


I would add the link to the reset procedure here as well as it is not clearly mentioned in the documentation. Something like "a reset is required after changing the card mode" and add the link

Updated the source accordingly, thanks!

dpopsuev · 2025-04-08T09:13:31Z

Good docs Ronan, LGTM

openshift-ci-robot · 2025-04-08T10:00:19Z

@rohennes: This pull request references TELCODOCS-2099 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

TELCODOCS-2099: Support for dual-port ordinary clock in PTP

Version(s):
4.19+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2099

Link to docs preview:

https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/about-ptp.html#ptp-dual-ports-oc_about-ptp

https://91166--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/configuring-ptp.html#configuring-linuxptp-services-oc-dual-port_configuring-ptp

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rohennes · 2025-04-08T15:06:44Z

/label peer-review-needed

dfitzmau

HI @rohennes .

Nice work! Thanks for the neat PR to review. I added comments inline.

dfitzmau · 2025-04-08T16:14:39Z

modules/nw-ptp-configuring-linuxptp-services-dual-port-oc.adoc

+* Install the OpenShift CLI (`oc`).
+* Log in as a user with `cluster-admin` privileges.
+* Install the PTP Operator.
+* The node uses an x86 architecture with a dual-port NIC.


Suggested change

* The node uses an x86 architecture with a dual-port NIC.

* The node uses an x86_64 architecture with a dual-port NIC.

If correct in the given context: https://redhat-documentation.github.io/supplementary-style-guide/#x86_64

dfitzmau · 2025-04-08T16:15:18Z

modules/nw-ptp-configuring-linuxptp-services-dual-port-oc.adoc

+      # Default Data Set
+      #
+      slaveOnly 1 <3>
+    #...


Suggested change

#...

# ...

networking/ptp/configuring-ptp.adoc

dfitzmau · 2025-04-08T16:17:47Z

modules/ptp-dual-ports-oc.adoc

+[id="ptp-dual-ports-oc_{context}"]
+= Using dual-port NICs to improve redundancy for PTP ordinary clocks
+
+{product-title} supports single and dual-port networking interface cards (NIC) as ordinary clocks for PTP timing. To improve redundancy, you can configure a dual-port NIC with one port as active and the other as standby.


Suggested change

{product-title} supports single and dual-port networking interface cards (NIC) as ordinary clocks for PTP timing. To improve redundancy, you can configure a dual-port NIC with one port as active and the other as standby.

{product-title} supports single and dual-port networking interface cards (NICs) as ordinary clocks for PTP timing. To improve redundancy, you can configure a dual-port NIC with one port as active and the other as standby.

modules/nw-ptp-configuring-linuxptp-services-dual-port-oc.adoc

modules/ptp-dual-ports-oc.adoc

dfitzmau · 2025-04-08T16:20:40Z

modules/ptp-dual-ports-oc.adoc

+
+* If the active port fails, the standby port transitions to active to ensure continued PTP timing synchronization.
+
+If both ports become faulty, the clock state moves to the `HOLDOVER` state, then the `FREERUN` state when the holdover timeout expires, before resyncing to a leader clock.


Suggested change

If both ports become faulty, the clock state moves to the `HOLDOVER` state, then the `FREERUN` state when the holdover timeout expires, before resyncing to a leader clock.

* If both ports become faulty before resyncing to a leader clock, the clock state moves to the `HOLDOVER` state, and then to the `FREERUN` state when the holdover timeout expires.

I think not technically accurate, but I did move this to a bullet point.

modules/ptp-dual-ports-oc.adoc

rohennes · 2025-04-09T10:38:51Z

HI @rohennes .

Nice work! Thanks for the neat PR to review. I added comments inline.

Thanks @dfitzmau , great review as always.

rohennes · 2025-04-09T10:41:02Z

/label merge-review-needed

openshift-ci · 2025-04-09T10:46:32Z

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xenolinux

lgtm merging

xenolinux · 2025-04-09T10:55:54Z

/cherrypick enterprise-4.19

openshift-cherrypick-robot · 2025-04-09T10:56:46Z

@xenolinux: new pull request created: #91907

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2025

rohennes force-pushed the TELCODOCS-2099 branch from 1ddd857 to 76c51cd Compare March 27, 2025 16:27

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2025

rohennes force-pushed the TELCODOCS-2099 branch 3 times, most recently from 420bd84 to aafa737 Compare March 28, 2025 15:12

rohennes force-pushed the TELCODOCS-2099 branch 2 times, most recently from 42a2c64 to acbd9af Compare March 31, 2025 10:48

edcdavid reviewed Mar 31, 2025

View reviewed changes

rohennes force-pushed the TELCODOCS-2099 branch from acbd9af to b5931e0 Compare March 31, 2025 15:56

edcdavid approved these changes Mar 31, 2025

View reviewed changes

rohennes force-pushed the TELCODOCS-2099 branch from b5931e0 to 0fe69ea Compare April 1, 2025 13:58

rohennes force-pushed the TELCODOCS-2099 branch from 0fe69ea to 5876c6c Compare April 8, 2025 09:19

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 8, 2025

dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 8, 2025

dfitzmau approved these changes Apr 8, 2025

View reviewed changes

dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.19 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 8, 2025

TELCODOCS-2099: Support for dual-port ordinary clock in PTP

61edb1c

rohennes force-pushed the TELCODOCS-2099 branch from 5876c6c to 61edb1c Compare April 9, 2025 10:38

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 9, 2025

xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 9, 2025

xenolinux added this to the Planned for 4.19 GA milestone Apr 9, 2025

xenolinux reviewed Apr 9, 2025

View reviewed changes

xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 9, 2025

xenolinux merged commit 8264910 into openshift:main Apr 9, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Apr 9, 2025

[enterprise-4.19] TELCODOCS-2099: Support for dual-port ordinary clock in PTP #91907

Merged

rohennes mentioned this pull request Jun 26, 2025

[enterprise-4.18] TELCODOCS-2360: Support for dual-port ordinary clock in PTP #95252

Merged

1 task

	* The node uses an x86 architecture with a dual-port NIC.
	* The node uses an x86_64 architecture with a dual-port NIC.

	{product-title} supports single and dual-port networking interface cards (NIC) as ordinary clocks for PTP timing. To improve redundancy, you can configure a dual-port NIC with one port as active and the other as standby.
	{product-title} supports single and dual-port networking interface cards (NICs) as ordinary clocks for PTP timing. To improve redundancy, you can configure a dual-port NIC with one port as active and the other as standby.


		* If the active port fails, the standby port transitions to active to ensure continued PTP timing synchronization.

		If both ports become faulty, the clock state moves to the `HOLDOVER` state, then the `FREERUN` state when the holdover timeout expires, before resyncing to a leader clock.

	If both ports become faulty, the clock state moves to the `HOLDOVER` state, then the `FREERUN` state when the holdover timeout expires, before resyncing to a leader clock.
	* If both ports become faulty before resyncing to a leader clock, the clock state moves to the `HOLDOVER` state, and then to the `FREERUN` state when the holdover timeout expires.

TELCODOCS-2099: Support for dual-port ordinary clock in PTP #91166

TELCODOCS-2099: Support for dual-port ordinary clock in PTP #91166

Uh oh!

Conversation

rohennes commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 28, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

edcdavid Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

rohennes Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

dpopsuev commented Apr 8, 2025

Uh oh!

openshift-ci-robot commented Apr 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohennes commented Apr 8, 2025

Uh oh!

dfitzmau left a comment

Choose a reason for hiding this comment

Uh oh!

dfitzmau Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

dfitzmau Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dfitzmau Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dfitzmau Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

rohennes Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rohennes commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohennes commented Apr 9, 2025

Uh oh!

openshift-ci bot commented Apr 9, 2025

Uh oh!

xenolinux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xenolinux commented Apr 9, 2025

Uh oh!

openshift-cherrypick-robot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rohennes commented Mar 27, 2025 •

edited

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Mar 27, 2025 •

edited

Loading

openshift-ci-robot commented Mar 28, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 8, 2025 •

edited by openshift-ci bot

Loading

rohennes Apr 9, 2025 •

edited

Loading

rohennes commented Apr 9, 2025 •

edited

Loading